Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #74: Include model_path in /meta endpoint response #100

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

Yuvrajsinghspd09
Copy link
Contributor

I updated the Meta.get() method in meta.py to include the model_path in the response. This makes it easy to find where the model is stored, especially in setups where file paths might be unclear.

The model_name was already included in the response, so I did not add it again. Adding only the model_path keeps the response clear and avoids repeating the same information.

@CaseyHaralson, I hope this addresses your request.

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 1   low 4   info 0 View in Orca
Passed Passed SAST high 0   medium 20   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca
🛡️ The following IaC misconfigurations have been detected
NAME FILE
medium Missing User Instruction Dockerfile View in code
low Healthcheck Instruction Missing Dockerfile View in code
low Pip install Keeping Cached Packages Dockerfile View in code
low Pip install Keeping Cached Packages Dockerfile View in code
low Unpinned Package Version in Pip Install Dockerfile View in code
🛡️ The following SAST misconfigurations have been detected
NAME FILE
medium Container Command Detected with Extended Privileges ..._push_custom_base.sh View in code
medium Container Command Detected with Extended Privileges cicd/docker_push.sh View in code
medium Missing timeout in requests module can cause DoS smoke_auth_test.py View in code
medium Missing timeout in requests module can cause DoS smoke_auth_test.py View in code
medium Missing timeout in requests module can cause DoS smoke_auth_test.py View in code
medium Missing timeout in requests module can cause DoS smoke_auth_test.py View in code
medium Missing timeout in requests module can cause DoS smoke_auth_test.py View in code
medium Missing timeout in requests module can cause DoS smoke_auth_test.py View in code
medium Missing timeout in requests module can cause DoS smoke_auth_test.py View in code
medium Missing timeout in requests module can cause DoS smoke_auth_test.py View in code
medium Missing timeout in requests module can cause DoS smoke_auth_test.py View in code
medium Missing timeout in requests module can cause DoS smoke_test.py View in code
medium Missing timeout in requests module can cause DoS smoke_test.py View in code
medium Missing timeout in requests module can cause DoS smoke_test.py View in code
medium Missing timeout in requests module can cause DoS smoke_test.py View in code
medium Missing timeout in requests module can cause DoS smoke_test.py View in code
medium Missing timeout in requests module can cause DoS test_app.py View in code
medium Missing timeout in requests module can cause DoS test_app.py View in code
medium Missing timeout in requests module can cause DoS test_app.py View in code
medium Security Risks of Using the Subprocess Module test_app.py View in code

@weaviate-git-bot
Copy link

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@Yuvrajsinghspd09
Copy link
Contributor Author

I agree to the Contributor License Agreement (CLA).

@antas-marcin antas-marcin merged commit 2590553 into weaviate:main Feb 1, 2025
43 checks passed
@antas-marcin
Copy link
Contributor

Thank you for your contibution! This fix will be a part of 1.10.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants