chore: Add flag to skip legacy duplicate telemetry #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have some legacy metrics with `peer_id` in the metrics suffix (in addition to same metrics with `peer_id`d as label) 1. `raft_replication_appendEntries_rpc_peer0` 2. `raft_replication_appendEntries_logs_peer0` 3. `raft_replication_heartbeat_peer0` 4. `raft_replication_installSnapshot_peer0` These metrics may have additional `_count` or `_sum` metrics. And each metrics are multiplicative. Meaning if I have 10 peers, these metrics will be 10x. This PR adds a flag `noLegacyTelemetry` (default: false) which by setting to `true` you can skip those duplicate metrics. Signed-off-by: Kaviraj <[email protected]>
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
Signed-off-by: Kaviraj <[email protected]>
Signed-off-by: Kaviraj <[email protected]>
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
Signed-off-by: Kaviraj <[email protected]>
Co-authored-by: Piotr Kazmierczak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge this PR first. That syncs the
mainwith upstreamCurrently we have some legacy metrics with
peer_idin the metrics suffix (in addition to same metrics withpeer_idd as label)raft_replication_appendEntries_rpc_peer0raft_replication_appendEntries_logs_peer0raft_replication_heartbeat_peer0raft_replication_installSnapshot_peer0These metrics may have additional
_countor_summetrics. And each metrics are multiplicative. Meaning if I have 10 peers, these metrics will be 10x.This PR adds a flag
noLegacyTelemetry(default: false) which by setting totrueyou can skip those duplicate metrics.Before
After