Log out the response in the error case.

weaveworks · Mar 1, 2023 · 700a8e0 · 700a8e0
1 parent 0c673b0
commit 700a8e0
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/controllers/templates/generators/apiclient/api_client.go b/controllers/templates/generators/apiclient/api_client.go
@@ -69,19 +69,18 @@ func (g *APIClientGenerator) Generate(ctx context.Context, sg *templatesv1.GitOp
 	}
 	defer resp.Body.Close()
 
-	// Anything 400+ is an error?
-	if resp.StatusCode >= http.StatusBadRequest {
-		// TODO: this should read the body and insert it?
-		g.Logger.Info("failed to fetch endpoint", "endpoint", sg.APIClient.Endpoint, "statusCode", resp.StatusCode)
-		return nil, fmt.Errorf("got %d response from endpoint %s", resp.StatusCode, sg.APIClient.Endpoint)
-	}
-
 	body, err := io.ReadAll(resp.Body)
 	if err != nil {
 		g.Logger.Error(err, "failed to read response", "endpoint", sg.APIClient.Endpoint)
 		return nil, err
 	}
 
+	// Anything 400+ is an error?
+	if resp.StatusCode >= http.StatusBadRequest {
+		g.Logger.Info("failed to fetch endpoint", "endpoint", sg.APIClient.Endpoint, "statusCode", resp.StatusCode, "response", string(body))
+		return nil, fmt.Errorf("got %d response from endpoint %s", resp.StatusCode, sg.APIClient.Endpoint)
+	}
+
 	if sg.APIClient.JSONPath == "" {
 		return g.generateFromResponseBody(body, sg.APIClient.Endpoint)
 	}