Skip to content

No log error CI #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

No log error CI #297

wants to merge 2 commits into from

Conversation

fayzal-g
Copy link

No description provided.

bboreham added 2 commits July 13, 2023 11:25
@bboreham
middleware: add a way to stop errors being logged
0f07c31 
E.g. if the error is caused by overload, then we don't want to log it
because that uses more resource.

Signed-off-by: Bryan Boreham <[email protected]>
@bboreham
Duh
d1f8877 
Signed-off-by: Bryan Boreham <[email protected]>
@bboreham
Copy link
Collaborator

OK how does this run CI for you and not for me?

@bboreham
Copy link
Collaborator

In the logs of my failed run:

Using environment variables from project settings and/or contexts:
  CIRCLE_OIDC_TOKEN=**REDACTED**
  CIRCLE_OIDC_TOKEN_V2=**REDACTED**
  CIRCLE_PLUGIN_TEST=**REDACTED**

Your successful run:

Using environment variables from project settings and/or contexts:
  CIRCLE_PLUGIN_TEST=**REDACTED**

I think this difference is because your PR comes from your fork and I pushed my branch to weaveworks/common.
So that gives a way forward for PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fayzal-g @bboreham