Merge upstream v0.15.0 #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "StackSnapshotType::All" for easier reading of trace steps, as shown in the picture. 
waiting for alloy-rs/alloy#1621 --------- Signed-off-by: jsvisa <[email protected]>
closes paradigmxyz#62 --------- Signed-off-by: jsvisa <[email protected]>
closes paradigmxyz#201 BTW, this will also change the public method `try_into_mux_frame`, so need to adjust in reth's side. --------- Signed-off-by: jsvisa <[email protected]>
replaces todo! with a revert outcome return value
…z#244) fixes paradigmxyz/reth#13089 btw, this PR also fixes the incorrect caller address in delegatecall. --------- Signed-off-by: jsvisa <[email protected]>
should close paradigmxyz#248 --------- Co-authored-by: Matthias Seitz <[email protected]>
For use in Foundry coverage guided fuzzing. I think the other functionality such as [comparing two edge maps](https://github.com/h0mbre/Lucid/blob/3026e7323c52b30b3cf12563954ac1eaa9c6981e/src/coverage.rs#L72) can be added later or in Foundry directly
- src/tracing/fourbyte.rs: Old: "byte" -> New: "bytes" Reason: Corrected to plural form since it refers to multiple (four) bytes - src/tracing/builder/parity.rs: Old: "Manually the gas used" -> New: "Manually set the gas used" Reason: Added missing verb "set" for grammatical completeness Documentation-only changes to improve clarity and correctness. No functional changes.
Right now caller is required to provide `AccessListInspector` with the list of precompiles which is unnecessary and requires caller to peek into EVM internals. Besides making API more complex this also results in reth not excluding p256 OP precompile when preparing access list https://github.com/paradigmxyz/reth/blob/890507a98adef94b3970312ef796eb40f87206df/crates/rpc/rpc-eth-api/src/helpers/call.rs#L430-L431 This PR changes `AccessListInspector` to obtain `from`, `to` and `precompiles` from the top-level frame and not requiring caller to provide anything
`self.enter_fn.is_some()` is used in the `can_call_exit` method to check for the presence of an entry function (`enter_fn`). This is incorrect, as the method should be checking for the exit function (`exit_fn`). I've fixed this by updating the check to `self.exit_fn.is_some()`. This aligns with the method's intended behavior.
### 1. File: `src/tracing/mux.rs` - **Old:** `/// A instance of FourByteInspector that can be reused` - **New:** `/// An instance of FourByteInspector that can be reused` - **Reason:** Corrected the grammatical error by changing "A" to "An" to ensure proper article usage before a vowel sound. ### 2. File: `src/tracing/utils.rs` - **Old:** `/// Returns a non empty revert reason if the output is a revert/error.` - **New:** `/// Returns a non-empty revert reason if the output is a revert/error.` - **Reason:** Added a hyphen to "non-empty" to correctly form the compound adjective, improving clarity and grammatical accuracy. ### 3. File: `src/transfer.rs` - **Old:** `/// A non zero value transfer CALL` - **New:** `/// A non-zero value transfer CALL` - **Reason:** Added a hyphen to "non-zero" to correctly form the compound adjective, enhancing clarity and grammatical correctness. ## Summary These changes improve the grammatical accuracy and clarity of the comments in the code, ensuring that the documentation is professional and easy to understand. Proper use of articles and hyphenation in compound adjectives is essential for maintaining high-quality code documentation.
## Description Bump alloy to the next version. --------- Co-authored-by: Matthias Seitz <[email protected]>
Old: //! Util functions for revm related ops New: //! Utility functions for revm related ops Reason: The word "Util" was replaced with "Utility" to improve readability and maintain consistency with standard English usage. This makes the comment more professional and easier to understand.
Revm Framework integration --------- Co-authored-by: Matthias Seitz <[email protected]> Co-authored-by: Arsenii Kulikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.