WIP: feat: add @weahead/commitlint-plugin-weahead #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first point of the required steps are done, the PR #3 is merged, the release of commitlint-plugin-weahead is left. |
lofgrenfredrik
approved these changes
Jan 8, 2020
|
@michaellopez Check it, then this is ready to be deployed as new version. 👍 |
michaellopez
commented
Jan 22, 2020
package.json
Outdated
| @@ -42,6 +42,7 @@ | |||
| "peerDependencies": { | |||
| "@commitlint/cli": ">=8", | |||
| "@commitlint/config-conventional": ">=8", | |||
| "@commitlint/prompt-cli": ">=8" | |||
| "@commitlint/prompt-cli": ">=8", | |||
| "@weahead/commitlint-plugin-weahead": ">=0.x" | |||
There was a problem hiding this comment.
Do we need .x in the version? Isn't >=0 enough?
There was a problem hiding this comment.
True!
Wasn't sure how we wanted to lock that dependency, updating the commit. 👍
lofgrenfredrik
force-pushed
the
feature/commitlint-plugin-weahead
branch
from
c1b6b66 to
54c790b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
This PR needs:
This PR adds @weahead/commitlint-plugin-weahead to the config. Only merge once #3 is merged and https://github.com/weahead/commitlint-plugin-weahead is released.