Open
Conversation
fletchapin
reviewed
Nov 25, 2025
Contributor
fletchapin
left a comment
fletchapin
left a comment
There was a problem hiding this comment.
The code looks good to me. It seems like the tests are failing because of this line in the GH Actions workflow: codecov -t ${{ secrets.CODECOV_TOKEN }}.
That has always worked for me in the past, but in this case it's giving the error:
codecov: error: argument --token/-t: expected one argument
So it appears that secrets.CODECOV_TOKEN is not getting properly populated. Perhaps it's a bug when merging in from a fork?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generalzies Network parsing code to work with a dictionary, instead of JSON directly.