-
Notifications
You must be signed in to change notification settings - Fork 38
feat(settings): add reviewed bulk cleanup flows #1754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JSONbored
wants to merge
10
commits into
we-promise:main
Choose a base branch
from
JSONbored:codex/feat-settings-bulk-cleanup-recreated
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b611165
feat(settings): add reviewed bulk cleanup flows
JSONbored bd0cf6c
fix(settings): repair bulk cleanup review issues
JSONbored aaac6e2
test(settings): assert bulk domain failure flash
JSONbored d7e970c
Merge branch 'main' into codex/feat-settings-bulk-cleanup-recreated
JSONbored 8d0ce80
fix(settings): harden bulk cleanup validation
JSONbored 94f6f91
test(settings): cover nil brandfetch domains
JSONbored cf4126e
Merge branch 'main' into codex/feat-settings-bulk-cleanup-recreated
JSONbored 98fe480
Merge branch 'main' into codex/feat-settings-bulk-cleanup-recreated
JSONbored a7e7b31
fix(accounts): resolve upstream account merge conflict
JSONbored d3499a2
Merge branch 'main' into codex/feat-settings-bulk-cleanup-recreated
JSONbored File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
app/javascript/controllers/merchant_merge_target_controller.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| import { Controller } from "@hotwired/stimulus" | ||
|
|
||
| const DISABLED_CLASSES = ["opacity-50", "pointer-events-none"] | ||
|
|
||
| export default class extends Controller { | ||
| static targets = [ | ||
| "existingSection", | ||
| "existingTarget", | ||
| "newSection", | ||
| "newTextInput", | ||
| "newColorInput" | ||
| ] | ||
| static values = { defaultColor: String } | ||
|
|
||
| connect() { | ||
| this.sync() | ||
| } | ||
|
|
||
| sync() { | ||
| const existingTargetSelected = this.existingTargetSelected() | ||
| const newTargetStarted = this.newTargetStarted() | ||
|
|
||
| if (existingTargetSelected) { | ||
| this.clearNewTargetFields() | ||
| } else if (newTargetStarted) { | ||
| this.clearExistingTarget() | ||
| } | ||
|
|
||
| this.setSectionDisabled(this.existingSectionTarget, !existingTargetSelected && newTargetStarted) | ||
| this.setSectionDisabled(this.newSectionTarget, existingTargetSelected) | ||
| } | ||
|
|
||
| beforeSubmit() { | ||
| this.sync() | ||
| } | ||
|
|
||
| newTargetStarted() { | ||
| const textEntered = this.newTextInputTargets.some((input) => input.value.trim() !== "") | ||
| const colorChanged = this.hasNewColorInputTarget && | ||
| this.defaultColorValue && | ||
| this.newColorInputTarget.value.toLowerCase() !== this.defaultColorValue.toLowerCase() | ||
|
|
||
| return textEntered || colorChanged | ||
| } | ||
|
|
||
| existingTargetSelected() { | ||
| return this.hasExistingTargetTarget && this.existingTargetTarget.value !== "" | ||
| } | ||
|
|
||
| clearExistingTarget() { | ||
| if (this.hasExistingTargetTarget) this.existingTargetTarget.value = "" | ||
| } | ||
|
|
||
| clearNewTargetFields() { | ||
| this.newTextInputTargets.forEach((input) => { | ||
| input.value = "" | ||
| }) | ||
|
|
||
| if (this.hasNewColorInputTarget && this.defaultColorValue) { | ||
| this.newColorInputTarget.value = this.defaultColorValue | ||
| } | ||
| } | ||
|
|
||
| setSectionDisabled(section, disabled) { | ||
| section.setAttribute("aria-disabled", disabled.toString()) | ||
| section.classList.toggle("cursor-not-allowed", disabled) | ||
| DISABLED_CLASSES.forEach((className) => section.classList.toggle(className, disabled)) | ||
|
|
||
| section.querySelectorAll("input, button, select, textarea").forEach((input) => { | ||
| input.disabled = disabled | ||
| }) | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.