Bank Sync cleanup

Procfile.dev

@@ -1,3 +1,3 @@
-web: bundle exec ${DEBUG:+rdbg -O -n -c --} bin/rails server
+web: bundle exec ${DEBUG:+rdbg -O -n -c --} bin/rails server -b 0.0.0.0 -p ${PORT:-3000}
 css: bundle exec bin/rails tailwindcss:watch 2>/dev/null
 worker: bundle exec sidekiq

app/components/DS/alert.html.erb

@@ -1,5 +1,5 @@
 <div class="<%= container_classes %>">
-  <%= helpers.icon icon_name, size: "sm", color: icon_color, class: "shrink-0" %>
+  <%= helpers.icon icon_name, size: "sm", color: icon_color, class: "shrink-0 mt-0.5" %>
 
   <div class="flex-1 text-sm">
     <%= message %>

app/components/settings/provider_card.html.erb

@@ -0,0 +1,25 @@
+<%= link_to connect_path,
+            class: "bg-container shadow-border-xs rounded-xl p-4 flex flex-col gap-2.5 text-primary hover:bg-container-hover transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-alpha-black-100",
+            data: { turbo_frame: "drawer", turbo_prefetch: "false" }.merge(filter_data) do %>
+  <div class="flex items-start gap-2.5">
+    <div class="w-9 h-9 rounded-lg flex items-center justify-center shrink-0 bg-surface-inset">
+      <span class="text-xs font-bold text-primary"><%= logo_text %></span>
+    </div>
+    <div class="flex-1 min-w-0">
+      <div class="flex items-center gap-2 flex-wrap">
+        <span class="text-sm font-medium text-primary"><%= name %></span>
+        <%= render "settings/providers/maturity_badge", label: maturity_label %>
+      </div>
+      <% if meta_line.present? %>
+        <p class="text-xs text-subdued mt-0.5"><%= meta_line %></p>
+      <% end %>
+    </div>
+  </div>
+  <% if tagline.present? %>
+    <p class="text-sm text-secondary grow leading-snug"><%= tagline %></p>
+  <% end %>
+  <div class="flex items-center justify-end gap-1.5 text-sm font-medium text-primary">
+    <%= t("settings.providers.connect") %>
+    <%= helpers.icon "arrow-right", size: "sm", class: "!w-3.5 !h-3.5" %>
+  </div>
+<% end %>

app/components/settings/provider_card.rb

@@ -0,0 +1,46 @@
+class Settings::ProviderCard < ApplicationComponent
+  MATURITY_LABELS = {
+    beta: "settings.providers.maturity.beta",
+    alpha: "settings.providers.maturity.alpha"
+  }.freeze
+
+  def self.maturity_label(maturity)
+    key = MATURITY_LABELS[maturity&.to_sym]
+    I18n.t(key) if key
+  end
+
+  def initialize(provider_key:, name:, tagline: nil, region: nil, kind: nil, tier: nil,
+                 maturity: :stable, logo_text: nil)
+    @provider_key = provider_key
+    @name         = name
+    @tagline      = tagline
+    @region       = region
+    @kind         = kind
+    @tier         = tier
+    @maturity     = maturity.to_sym
+    @logo_text    = logo_text || name.first(2).upcase
+  end
+
+  attr_reader :name, :tagline, :logo_text
+
+  def maturity_label
+    self.class.maturity_label(@maturity)
+  end
+
+  def meta_line
+    [ @region, @kind, @tier ].compact.join(" · ")
+  end
+
+  def connect_path
+    helpers.connect_form_settings_providers_path(provider_key: @provider_key)
+  end
+
+  def filter_data
+    {
+      providers_filter_target: "card",
+      provider_name: @name.to_s.downcase,
+      provider_region: @region.to_s.downcase,
+      provider_kind: @kind.to_s.downcase
+    }
+  end
+end

app/controllers/settings/providers_controller.rb

@@ -1,12 +1,12 @@
 class Settings::ProvidersController < ApplicationController
-  layout "settings"
+  layout -> { turbo_frame_request? ? "turbo_rails/frame" : "settings" }
 
-  before_action :ensure_admin, only: [ :show, :update ]
+  before_action :ensure_admin, only: [ :show, :update, :sync_all, :sync, :connect_form ]
 
   def show
     @breadcrumbs = [
       [ "Home", root_path ],
-      [ "Bank Sync Providers", nil ]
+      [ "Bank sync", nil ]
     ]
 
     prepare_show_context
@@ -77,6 +77,61 @@ def update
     render :show, status: :unprocessable_entity
   end
 
+  def sync_all
+    family = Current.family
+    now = Time.current
+
+    updated_count = Family
+      .where(id: family.id)
+      .where("last_sync_all_attempted_at IS NULL OR last_sync_all_attempted_at <= ?", 30.seconds.ago)
+      .update_all(last_sync_all_attempted_at: now, updated_at: now)
+
+    if updated_count.zero?
+      return redirect_to settings_providers_path, notice: t("settings.providers.sync_all_recently")
+    end
+
+    SyncAllProvidersJob.perform_later(family.id)
+    redirect_to settings_providers_path, notice: t("settings.providers.sync_all_in_progress")
+  end
+
+  def sync
+    provider_key  = params[:provider_key]
+    syncable_type = PANEL_SYNCABLE_TYPES[provider_key]
+    return redirect_to settings_providers_path unless syncable_type
+
+    items = syncable_type.constantize.where(family: Current.family).syncable
+    scheduled = items.reject(&:syncing?)
+    scheduled.each(&:sync_later)
+
+    notice_key = scheduled.any? ? "settings.providers.sync_provider_in_progress" : "settings.providers.sync_provider_no_items"
+    redirect_to settings_providers_path, notice: t(notice_key)
+  end
+
+  def connect_form
+    provider_key = params[:provider_key]
+
+    panel = FAMILY_PANELS.find { |p| p[:key] == provider_key }
+    if panel
+      @panel_key     = panel[:key]
+      @panel_partial = panel[:partial]
+      @panel_title   = panel[:title]
+      load_provider_items(provider_key)
+      return render :connect_form
+    end
+
+    Provider::Factory.ensure_adapters_loaded
+    config = Provider::ConfigurationRegistry.all.find { |c| c.provider_key.to_s == provider_key }
+    if config
+      @panel_title           = Provider::Metadata.for(provider_key)[:name] || provider_key.titleize
+      @provider_configuration = config
+      return render :connect_form
+    end
+
+    redirect_to settings_providers_path, alert: t("settings.providers.not_found")
+  rescue ActiveRecord::Encryption::Errors::Configuration
+    redirect_to settings_providers_path, alert: t("settings.providers.encryption_error.title")
+  end
+
   private
     def provider_params
       # Dynamically permit all provider configuration fields
@@ -93,7 +148,9 @@ def provider_params
     end
 
     def ensure_admin
-      redirect_to settings_providers_path, alert: "Not authorized" unless Current.user.admin?
+      return if Current.user.admin?
+
+      redirect_to root_path, alert: t("settings.providers.not_authorized")
     end
 
     # Reload provider configurations after settings update
@@ -119,19 +176,71 @@ def reload_provider_configs(updated_fields)
       end
     end
 
+    # Hardcoded family-scoped panels — provider connections are managed through
+    # their own models (SimplefinItem, LunchflowItem, etc.) rather than global
+    # settings, so they need custom UI per-provider for connection management,
+    # status display, and sync actions. The configuration registry excludes
+    # them (see prepare_show_context).
+    FAMILY_PANELS = [
+      { key: "lunchflow",      title: "Lunch Flow",      turbo_id: "lunchflow",      partial: "lunchflow_panel" },
+      { key: "simplefin",      title: "SimpleFIN",       turbo_id: "simplefin",      partial: "simplefin_panel" },
+      { key: "enable_banking", title: "Enable Banking",  turbo_id: "enable_banking", partial: "enable_banking_panel" },
+      { key: "coinstats",      title: "CoinStats",       turbo_id: "coinstats",      partial: "coinstats_panel" },
+      { key: "mercury",        title: "Mercury",         turbo_id: "mercury",        partial: "mercury_panel" },
+      { key: "coinbase",       title: "Coinbase",        turbo_id: "coinbase",       partial: "coinbase_panel" },
+      { key: "binance",        title: "Binance",         turbo_id: "binance",        partial: "binance_panel" },
+      { key: "snaptrade",      title: "SnapTrade",       turbo_id: "snaptrade",      partial: "snaptrade_panel", auto_open: "manage" },
+      { key: "indexa_capital", title: "Indexa Capital",  turbo_id: "indexa_capital", partial: "indexa_capital_panel" },
+      { key: "sophtron",       title: "Sophtron",        turbo_id: "sophtron",       partial: "sophtron_panel" }
+    ].freeze
+
+    FAMILY_PANEL_KEYS = FAMILY_PANELS.map { |p| p[:key] }.freeze
+
+    # Maps panel key → ActiveRecord model name for sync health queries
+    PANEL_SYNCABLE_TYPES = {
+      "simplefin"      => "SimplefinItem",
+      "lunchflow"      => "LunchflowItem",
+      "enable_banking" => "EnableBankingItem",
+      "coinstats"      => "CoinstatsItem",
+      "mercury"        => "MercuryItem",
+      "coinbase"       => "CoinbaseItem",
+      "binance"        => "BinanceItem",
+      "snaptrade"      => "SnaptradeItem",
+      "indexa_capital" => "IndexaCapitalItem",
+      "sophtron"       => "SophtronItem"
+    }.freeze
+
+    def load_provider_items(provider_key)
+      case provider_key
+      when "simplefin"
+        @simplefin_items = Current.family.simplefin_items.ordered
+      when "lunchflow"
+        @lunchflow_items = Current.family.lunchflow_items.ordered
+      when "enable_banking"
+        @enable_banking_items = Current.family.enable_banking_items.ordered
+      when "coinstats"
+        @coinstats_items = Current.family.coinstats_items.ordered
+      when "mercury"
+        @mercury_items = Current.family.mercury_items.active.ordered.includes(:syncs, :mercury_accounts)
+      when "coinbase"
+        @coinbase_items = Current.family.coinbase_items.ordered
+      when "binance"
+        @binance_items = Current.family.binance_items.active.ordered
+      when "snaptrade"
+        @snaptrade_items = Current.family.snaptrade_items.includes(:snaptrade_accounts).ordered
+      when "indexa_capital"
+        @indexa_capital_items = Current.family.indexa_capital_items.ordered
+      when "sophtron"
+        @sophtron_items = Current.family.sophtron_items.ordered
+      end
+    end
+
     # Prepares instance vars needed by the show view and partials
     def prepare_show_context
-      # Load all provider configurations (exclude SimpleFin and Lunchflow, which have their own family-specific panels below)
+      # Load all provider configurations (exclude family-scoped panels, which have their own UI below)
       Provider::Factory.ensure_adapters_loaded
       @provider_configurations = Provider::ConfigurationRegistry.all.reject do |config|
-        config.provider_key.to_s.casecmp("simplefin").zero? || config.provider_key.to_s.casecmp("lunchflow").zero? || \
-        config.provider_key.to_s.casecmp("enable_banking").zero?  || \
-        config.provider_key.to_s.casecmp("sophtron").zero? || \
-        config.provider_key.to_s.casecmp("coinstats").zero? || \
-        config.provider_key.to_s.casecmp("mercury").zero? || \
-        config.provider_key.to_s.casecmp("coinbase").zero? || \
-        config.provider_key.to_s.casecmp("snaptrade").zero? || \
-        config.provider_key.to_s.casecmp("indexa_capital").zero?
+        FAMILY_PANEL_KEYS.any? { |key| config.provider_key.to_s.casecmp(key).zero? }
       end
 
       # Providers page only needs to know whether any SimpleFin/Lunchflow connections exist with valid credentials
@@ -141,9 +250,98 @@ def prepare_show_context
       # Providers page only needs to know whether any Sophtron connections exist with valid credentials
       @sophtron_items = Current.family.sophtron_items.where.not(user_id: [ nil, "" ], access_key: [ nil, "" ]).ordered.select(:id)
       @coinstats_items = Current.family.coinstats_items.ordered # CoinStats panel needs account info for status display
-      @mercury_items = Current.family.mercury_items.active.ordered.includes(:syncs, :mercury_accounts)
+      @mercury_items = Current.family.mercury_items.active.ordered
       @coinbase_items = Current.family.coinbase_items.ordered # Coinbase panel needs name and sync info for status display
-      @snaptrade_items = Current.family.snaptrade_items.includes(:snaptrade_accounts).ordered
+      @snaptrade_items = Current.family.snaptrade_items.ordered
       @indexa_capital_items = Current.family.indexa_capital_items.ordered.select(:id)
+      @binance_items = Current.family.binance_items.active.ordered
+
+      @provider_sync_health = compute_provider_sync_health(family_panel_items)
+
+      entries = build_provider_entries
+
+      @connected        = entries.select { |e| e[:summary][:status] == :ok }
+      @needs_attention  = entries.select { |e| [ :warn, :err ].include?(e[:summary][:status]) }
+      @available        = entries.select { |e| e[:summary][:status] == :off }
+    end
+
+    # Maps each family panel key to the loaded item collection. Used by
+    # compute_provider_sync_health and build_provider_entries to avoid relying
+    # on instance_variable_get for control flow.
+    def family_panel_items
+      {
+        "simplefin"      => @simplefin_items,
+        "lunchflow"      => @lunchflow_items,
+        "enable_banking" => @enable_banking_items,
+        "coinstats"      => @coinstats_items,
+        "mercury"        => @mercury_items,
+        "coinbase"       => @coinbase_items,
+        "binance"        => @binance_items,
+        "snaptrade"      => @snaptrade_items,
+        "indexa_capital" => @indexa_capital_items,
+        "sophtron"       => @sophtron_items
+      }
+    end
+
+    # Returns a hash mapping provider key → { error:, last_synced_at:, stale: }
+    # by querying the latest sync per item for each family panel provider.
+    def compute_provider_sync_health(items_map)
+      PANEL_SYNCABLE_TYPES.each_with_object({}) do |(key, syncable_type), health|
+        ids = items_map[key]&.map(&:id)&.compact
+        next if ids.blank?
+
+        health[key] = sync_health_for(syncable_type, ids)
+      end
+    end
+
+    # Determines error/stale status and last successful sync time for a set of items.
+    def sync_health_for(syncable_type, item_ids)
+      # Use window function to get the single latest sync per item (same pattern as ProviderConnectionStatus)
+      ranked_subq = Sync
+        .where(syncable_type: syncable_type, syncable_id: item_ids)
+        .select("syncs.*, ROW_NUMBER() OVER (PARTITION BY syncable_id ORDER BY created_at DESC, id DESC) AS sync_rank")
+
+      latest_per_item = Sync.from(ranked_subq, :syncs).where("sync_rank = 1").to_a
+
+      has_error = latest_per_item.any? { |s| s.failed? || s.stale? }
+
+      last_synced = Sync
+        .where(syncable_type: syncable_type, syncable_id: item_ids, status: "completed")
+        .maximum(:completed_at)
+
+      stale = !has_error && last_synced.present? && last_synced < 24.hours.ago
+
+      { error: has_error, last_synced_at: last_synced, stale: stale }
+    end
+
+    # Builds a unified list of provider entries (registry-driven configurations
+    # and hardcoded family panels) with pre-computed status, sorted
+    # alphabetically by display title. Each entry carries enough data for the
+    # view to render either a provider_form or a family panel partial.
+    def build_provider_entries
+      configuration_entries = @provider_configurations.map do |config|
+        meta = Provider::Metadata.for(config.provider_key)
+        {
+          provider_key: config.provider_key.to_s,
+          title: meta[:name] || config.provider_key.to_s.titleize,
+          configuration: config,
+          maturity: meta[:maturity],
+          summary: view_context.provider_summary(config.provider_key)
+        }
+      end
+
+      family_entries = FAMILY_PANELS.map do |panel|
+        {
+          provider_key: panel[:key],
+          title: panel[:title],
+          turbo_id: panel[:turbo_id],
+          partial: panel[:partial],
+          auto_open_param: panel[:auto_open],
+          maturity: Provider::Metadata.for(panel[:key])[:maturity],
+          summary: view_context.provider_summary(panel[:key])
+        }
+      end
+
+      (configuration_entries + family_entries).sort_by { |entry| entry[:title].downcase }
     end
 end