-
Notifications
You must be signed in to change notification settings - Fork 6
feat(api): expose complete account export state #1597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jjmata
merged 7 commits into
we-promise:main
from
JSONbored:feat/api-account-export-parity
May 1, 2026
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
41204ef
feat(api): expose complete account export state
JSONbored a19c8b6
fix(api): handle malformed account identifiers
JSONbored 94617dd
fix(api): tighten account export contracts
JSONbored 443cfa2
fix(api): correct account id OpenAPI format
JSONbored 9b4e591
fix(api): tighten account docs auth contracts
JSONbored 7364df3
docs(api): document balance sheet auth errors
JSONbored a85a953
docs(api): clarify account scope fixture
JSONbored File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| balance_money = account.balance_money | ||
| cash_balance_money = account.cash_balance_money | ||
|
|
||
| json.id account.id | ||
| json.name account.name | ||
| json.balance balance_money.format | ||
| json.balance_cents((balance_money.amount * balance_money.currency.minor_unit_conversion).round(0).to_i) | ||
| json.cash_balance cash_balance_money.format | ||
| json.cash_balance_cents((cash_balance_money.amount * cash_balance_money.currency.minor_unit_conversion).round(0).to_i) | ||
| json.currency account.currency | ||
| json.classification account.classification | ||
| json.account_type account.accountable_type&.underscore | ||
| json.subtype account.subtype | ||
| json.status account.status | ||
| json.institution_name account.institution_name | ||
| json.institution_domain account.institution_domain | ||
| json.created_at account.created_at.iso8601 | ||
| json.updated_at account.updated_at.iso8601 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| json.partial! "account", account: @account |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.