Azhar tunr_express#161
Open
mdazharaw wants to merge 26 commits into
Open
Conversation
Id fixing
Author
Updated 21 April 2020
|
Author
Updated 22 Apr 2020:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deliverable Submission
Please describe your comfort and completeness levels before submitting. Comfort Level (1-5):
3
Completeness Level (1-5):
2
How many hours did you spend on this assignment?
3
What part did you spend the most time on?
Part 1 done, Part 2 Restful Routing Delete still in progress
Does the assignment run without errors? If the assignment has errors, what are they?
Yes.
Describe one part of the code or choose one line you would improve upon. What would you improve?
Work in progress
What did you think of this deliverable? Any other comments?
Updated 20 Apr 2020:
Please describe your comfort and completeness levels before submitting. Comfort Level (1-5):
3
Completeness Level (1-5):
3
How many hours did you spend on this assignment?
8
What part did you spend the most time on?
Writing up the working SQL queries and manipulating id of different tables
Does the assignment run without errors? If the assignment has errors, what are they?
Error when loading new playlist, first 2 playlists are working but beyond that other playlists not accessible, possibly due to id issues.
Describe one part of the code or choose one line you would improve upon. What would you improve?
Restructure code to work with ids given from table and not reassign id to rows.
What did you think of this deliverable? Any other comments?
Challenging