P's pull request#39
Open
yJiaYi wants to merge 15 commits into
Open
Conversation
added 15 commits
October 5, 2017 00:28
primaulia
reviewed
Oct 9, 2017
| ] | ||
|
|
||
| // targeting elements | ||
| var $h1 = $('h1') |
Contributor
There was a problem hiding this comment.
This line onward is not indented properly
primaulia
reviewed
Oct 9, 2017
| top: 10px; | ||
| } | ||
|
|
||
| #daffy { |
Contributor
There was a problem hiding this comment.
Why it needs to be absolute positioned?
primaulia
reviewed
Oct 9, 2017
| position: relative; | ||
| left: 100px; | ||
| text-transform: uppercase; | ||
|
|
primaulia
reviewed
Oct 9, 2017
| } | ||
|
|
||
| .container { | ||
| width: 700px; |
primaulia
reviewed
Oct 9, 2017
| text-transform:uppercase; | ||
| position: relative; | ||
| top: 50px; | ||
| right: 20px;` ` |
Contributor
There was a problem hiding this comment.
There's backtick (`) here, please clean it out
Contributor
|
Project Workflow: 2 / 5
Glow
Grow
Things to look out for
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.