readme update by thamjieying · Pull Request #35 · wdi-sg/project-1

thamjieying · 2017-09-30T05:05:19Z

No description provided.

primaulia · 2017-10-08T02:43:05Z

+[7,3,3,3,3,8]
+]
+
+//array indicating the exits


I think it's not necessary to split these two arrays (map and exit), but good that you justify why in the presentation.

primaulia · 2017-10-08T02:48:54Z

@@ -0,0 +1,76 @@
+<!DOCTYPE html>


Good job on separating the concern of each level into different html 👍

I hope you realized that this is tedious, but this is inevitable in unit 1.

primaulia · 2017-10-08T02:50:25Z

+  // SET THE MAP
+  map.forEach(function(spotY,indexY) {
+    spotY.forEach(function(spot, indexX){
+    switch (spot) {


One of the few good application of switch :)

primaulia · 2017-10-08T02:52:31Z

+    counter=0
+
+    //playerMovement
+  if(!isExit() && clicker){


indentation issue here

primaulia · 2017-10-08T03:16:20Z

Project Workflow: 4 / 5
Technical Requirement: 5 / 5
Creativity: 5 / 5
Code Quality: 4 / 5
Problem Solving: 4 / 5
Delivery: 3 / 5
Professional Skill: 4 / 5

Glow

Very good well-thought game logic and game mechanism
Code is written in a very systematic manner and easy to follow
Project description is fine-grained and detailed, yet easy to understand

Grow

Your delivery can be more engaging and fun, the game is pretty interesting :)
Make your codes more DRY, look back on your project 1 after you're done with unit 2
Try to solve my challenges by randomizing the maze

Things to look for

MVC structure, we'll cover this on unit 2
Class & Constructor, perhaps this will help you to randomize the game better

alexkimin · 2017-10-08T04:57:02Z

@@ -0,0 +1,76 @@
+<!DOCTYPE html>


You can complete your game without split files of html. I believe you will figure that out. Focus on reducing repetition.

alexkimin · 2017-10-08T05:04:02Z

+
+    //playerMovement
+  if(!isExit() && clicker){
+    switch(e.keyCode){


What will be cons and pros of switch statement with a few case?

if(!isExit() && clicker) { if(e.keyCode === 37 && !checkXBlockLeft(charPos)) charMoveLeft() if(e.keyCode === 38 && !checkYBlockTop(charPos)) charMoveUp() if(e.keyCode === 39 && !checkXBlockRight(charPos)) charMoveRight() if(e.keyCode === 40 && !checkYBlockBottom(charPos))charMoveDown() mummyFollowChar() meetMummy() }

alexkimin · 2017-10-08T05:07:10Z

@@ -0,0 +1,30 @@
+//layout for blockage


Without file splitting and linking to particular html file, I believe you can generate levels with javascript. :) It will be helpful for scalability of levels.

alexkimin · 2017-10-08T05:14:12Z

+function mummyFollowChar(){
+  counter = 0
+  mumPos = map[mumY][mumX]
+  if(counter <2){


You may reduce some repetition here. How?

alexkimin · 2017-10-08T05:17:40Z

@@ -0,0 +1,23 @@
+  function charMoveLeft(){


Your movement functions are called inside of callback function of the keyborad event listener. Then what if I put var position = $('#player').position() line to line 4 of gameplay.js?

alexkimin · 2017-10-08T05:22:22Z

+  // SET THE MAP
+  map.forEach(function(spotY,indexY) {
+    spotY.forEach(function(spot, indexX){
+    switch (spot) {


Good 'switch approach with many cases. :)

And you may do this with 2-D Array and in statement for replacing each switch statement.

e.g.

var arr = [[1,5,6,9,11,12,14], [ ...... ], [......], .........] if( spot in arr[0] ) $wrapper.eq(indexY).find('.box').eq(indexX).addClass('top')

alexkimin · 2017-10-08T05:25:08Z

+
+  // SET THE MAP
+  map.forEach(function(spotY,indexY) {
+    spotY.forEach(function(spot, indexX){


What are the cons and pros of forEach()comparing with for-loop?

alexkimin · 2017-10-08T05:28:12Z

+
+//checing relative x-position of mummy to player
+function checkXPos(mumX, charX){
+  if(mumX === charX){


You may refactor here

return mumX === charX

alexkimin · 2017-10-08T05:28:54Z

+
+//checking relative y-position from mummy to player
+function checkYPos(mumY, charY){
+  if(mumY === charY){


same as line 110

alexkimin · 2017-10-08T05:31:48Z

+
+//checking x-blockage
+function checkXBlockLeft(x){
+  switch(x){


For your inspiration.

function checkXBlockLeft(x){ var block = [4,5,7,10,11,13,14] return x in block }

alexkimin · 2017-10-08T05:39:04Z

Project Workflow: 4 / 5
Technical Requirement: 5 / 5
Creativity: 4 / 5
Code Quality: 3 / 5
Problem Solving: 4 / 5

Glow

Strong understanding of own logic and solid way of thinking.

Grow

You can try various method or approach for doing same things.
Check cons and pros of several Iteration and Condition flow.
If you follow DRY principle, the code will be more tidy and clean.

Things to look for

Class & Constructor.
How to avoid using a global scope.

thamjieying added 17 commits September 30, 2017 13:04

readme update

e0d38c9

first draft

7b67a6c

draft 2

143651d

draft 3

b232e9e

draft

a729271

draft 3

1e59561

draft 3

aeb2729

draft 3

479cc16

draft 3

7128304

draft3

acf6a14

draft 3

6e6012e

draft 3

291d82d

draft 3

118791a

kko

987957b

draft 3

5be2d5c

draft 3

a306ce0

draft 4

7e44c90

primaulia reviewed Oct 8, 2017

View reviewed changes

Comment thread js/gamePlay.js

counter=0

//playerMovement

if(!isExit() && clicker){

Copy link
Copy Markdown

Contributor

primaulia Oct 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation issue here

alexkimin reviewed Oct 8, 2017

View reviewed changes

thamjieying added 3 commits December 13, 2017 09:54

changes to css

2a85eed

edited alert messages

4bcdcfb

updated instruction page

298654e

Conversation

thamjieying commented Sep 30, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

primaulia commented Oct 8, 2017

Glow

Grow

Things to look for

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexkimin Oct 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexkimin Oct 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexkimin Oct 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexkimin Oct 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexkimin Oct 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexkimin Oct 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexkimin commented Oct 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Glow

Grow

Things to look for

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alexkimin Oct 8, 2017 •

edited

Loading

alexkimin Oct 8, 2017 •

edited

Loading

alexkimin Oct 8, 2017 •

edited

Loading

alexkimin Oct 8, 2017 •

edited

Loading

alexkimin Oct 8, 2017 •

edited

Loading

alexkimin Oct 8, 2017 •

edited

Loading

alexkimin commented Oct 8, 2017 •

edited

Loading