On the other side by itsgabrielu · Pull Request #28 · wdi-sg/project-1

itsgabrielu · 2017-09-29T16:45:04Z

Readme and flowchart edit

… muteBeep

primaulia · 2017-10-06T06:34:03Z

+var jumpLimit = true // switch for jump
+var start1 = [] // indicates ball1 starting position, index position increases with level
+var start2 = []
+var currentLevel


What does this variable for?

primaulia · 2017-10-06T06:34:31Z

+  }
+}
+function wallCheck1Right () {
+  if (($ball1.position().left + $ball1.width() >= $('.wall1').eq(0).position().left) &&


How would you rectified this repetitions?

soemn · 2017-10-06T18:25:48Z

-    **1** | _Does not meet expectations._
-    **2** | _Meets expectations, good job!_
-    **3** | _Exceeds expectations, you wonderful creature, you!_
+I also used wikipedia for the gravity formula, but it seems the page no longer looks the same, or I can't find it. But [here's](http://www.school-for-champions.com/science/gravity_equations_falling_displacement.htm#.WdXiRROCzVo) another resource you can use to see the gravity displacement.


The general equation is from kinematics, for displacement with constant acceleration.
See http://www.physicsclassroom.com/class/1DKin/Lesson-6/Kinematic-Equations.

Where d is the displacement, v(i) is initial velocity, a is acceleration (in this case, a = g) and t is time

primaulia · 2017-10-09T15:44:17Z

  <body>
-    <script src="js/script.js" charset="utf-8"></script>
+    <h1> On The Other Side </h1>
+    <h3> <br> </h3>


what's the <br> for?

I had put it to push down the game halves lower from the h1 element

primaulia · 2017-10-10T14:33:08Z

+        <div id = "clear"></div>
+
+      </div>
+      <button type="button" id = "mute" class="mute"> I like sounds (M)</button>


no space please => id="mute"

primaulia · 2017-10-10T14:34:37Z

+      <p> Help steer Blue and Red into the grey boxes to win. <br>
+        <strong>You can only move Blue directly</strong> with W,A,D or &uarr;,&larr;,&rarr;. <br>
+        Red will go opposite in the horizontal plane.<br></p>
+        <br><br>


please group your html into a more logical grouping

primaulia · 2017-10-10T14:39:12Z

@@ -0,0 +1,548 @@
+var $ball1 = $('#ball1')


Line 1 to line 18 should be after $(function () {

primaulia · 2017-10-10T14:42:21Z

+    function ballMove (e) {
+      var unit = 20 // 20
+      if (e.key === 'd' || e.key === 'D' || e.key === 'ArrowRight') {
+        if (ball1Goal() === false && (borderCheck1Right()) && (wallCheck1Right()) && (!$('.fade').length)) ball1Hori(unit) // if ball1 doesn't exceed right border


that's a really long condition, can we shorten this instead in a function?

primaulia · 2017-10-10T14:42:51Z

+      }
+      if (e.key === 'w' || e.key === 'W' || e.key === 'ArrowUp') {
+        if (jumpLimit) {
+          if (!ball1Goal()) ball1Jump()


Why can't just there be one function that checks goal for both balls?

This is to let both balls be independent from each other, when a single ball goes into the goal, it will be frozen, while the other ball can still move/jump.

primaulia · 2017-10-10T14:46:12Z

+})
+
+// this controls horizontal ball movement
+function ball1Hori (a) {


indentation, and repeated.

What is a?

a represents an argument that we eventually use, e.g.: in line, 31: var unit = 20 to indicate the amount of pixels moved per keyboard move:
ball1Hori(unit) to indicate movement to the right
ball1Hori(-unit) to indicate movement to the left

primaulia · 2017-10-10T14:46:41Z

+  document.getElementById('ball1').style.left = (Number($ball1.css('left').replace('px', '')) + a).toString() + 'px'
+}
+function ball2Hori (a) {
+  document.getElementById('ball2').style.left = (Number($ball2.css('left').replace('px', '')) - a).toString() + 'px'


mixing jquery with document.getElementById(), choose one and stick with it.

Hmm i remember for this one, .css(top) and .position.top actually represent different values on the screen, so used .style to edit the ball placement,which seems to be only for non jquery manipulators ( i might be wrong!)

primaulia · 2017-10-10T14:51:43Z

+    return true
+  }
+}
+function wallCheck2Right () {


Refactor, refactor, refactor

primaulia · 2017-10-10T14:53:53Z

+        break
+    }
+  }
+}


whew. what just happened

this section of code represents when the user wins the current level. The logic which checks the winning condition is actually on a set interval, which also populates a nextLevel button. So in order to stop adding multiple buttons continously, we clear this interval, while adding a button which leads to the next level.

primaulia · 2017-10-10T15:12:28Z

Project Workflow: 4 / 5
Technical Requirement: 3 / 5
Creativity: 4 / 5
Code Quality: 2 / 5
Problem Solving: 3 / 5
Delivery: 4 / 5
Professional Skill: 4 / 5

Glow

Interesting game concept, nice that you applied what you've learnt to what you really want to do
Delivery is concise and succinct
Applaud your attempt on doing this in a brute force attempt
Workflow was good, but quite messy

Grow & Things to look out for

Too many repetitions, I would ask you to repeat your codes line by line if this is not a 12 week course. I hope you've learnt that the amount of repetitions in your code here is alarming. Make sure that you look back on what you did every few minutes and not just piling up codes
A bad habit on not standardizing your way of coding, there are some parts that used space some that are not. Do look into this for your future development.

shumin13 · 2017-10-12T08:31:02Z

Glow

Interesting game concept
Good implementation of the skip and reset button
Clear commit messages

Grow & Things to look out for

Good effort on the Readme but can be more concise. Can also look into https://help.github.com/articles/basic-writing-and-formatting-syntax/ for formatting syntax
Can look into https://coolors.co/ to enhance your design
Good to hide reset and skip button before the start button is clicked
Indicated the wrong year on the website
You may want to keep the sound credits to readme
The game is still quite buggy. May want to edit it before the M&G

itsgabrielu added 30 commits September 29, 2017 18:29

Version 1.0 flow readme

ff2ccac

README and flowchart v1.1

737804d

Created two game halves, with opposite moving balls

0ad26da

added mirrored borderchecks, updated README

459b4e0

Added ballSnap feature to check periodically if balls are out of frame

fc761c1

Added goal constructor and section comments

a62f7b7

Added winning logic and conditions

c19f6e1

Added ball gravity1 gravity2

d992d13

Updated gravity and added jump feature

25bb22c

level one set up

f310246

updated gravity and added arrow keys

efe180c

Built demo v2

3ec679e

built demo v2

f02d03a

Level 1 transition added

086ebd9

Added level transition and level 2

b8b327a

3 levels

ceb34c0

Added reset tagged to previous goal locations, to toggle nextLevel

aa105ee

Added basic start button

e6dccc1

Added website formating, instructions

89eff2c

Added button hotkeys, update css

7e44cad

master branch preview

5ed0653

updated asset links

077d645

Added jump sound, credits section

fb28db4

Default mute, mute toggle added

28a851d

Updated asset links, added project 1 flowchart, updated readme, added…

daaf0a7

… muteBeep

updated asset links

b0b12bc

weird audio api

dc72e10

Final copy before code freeze

92fb945

added my sig

c08eee3

change link

e314106

removing space from file name to link properly

aedd583

primaulia reviewed Oct 6, 2017

View reviewed changes

soemn reviewed Oct 6, 2017

View reviewed changes

primaulia reviewed Oct 9, 2017

View reviewed changes

primaulia reviewed Oct 10, 2017

View reviewed changes

Comment thread assets/js/script.js

return true

}

}

function wallCheck2Right () {

Copy link
Copy Markdown

Contributor

primaulia Oct 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor, refactor, refactor

primaulia reviewed Oct 10, 2017

View reviewed changes

adjusted CSS

97ee26d

Conversation

itsgabrielu commented Sep 29, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

itsgabrielu Oct 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

primaulia Oct 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

primaulia commented Oct 10, 2017

Glow

Grow & Things to look out for

Uh oh!

shumin13 commented Oct 12, 2017

Glow

Grow & Things to look out for

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

itsgabrielu Oct 10, 2017 •

edited

Loading

primaulia Oct 10, 2017 •

edited

Loading