created readme and forgot to make pull request ><#27
Open
jpung wants to merge 23 commits into
Open
Conversation
Siya-ng
reviewed
Oct 9, 2017
| }, 30) | ||
|
|
||
| $body.on('keydown', function (e) { //player keyboard press detection | ||
| var $player = $('.player') |
Author
There was a problem hiding this comment.
yeah was used for the checking portion when i was running the code, again i forgot to remove :(
Siya-ng
reviewed
Oct 9, 2017
| $bulletLoc = $bullet.position() | ||
| $bulletExact = $bulletLoc.left | ||
| $bulletTop = $playPos.top | ||
| $bulletLeft = $playPos.left |
There was a problem hiding this comment.
$bulletLeft is not used in any part of the script. Any reason for this var?
Author
There was a problem hiding this comment.
nope, forgot to take out after refactoring code
Siya-ng
reviewed
Oct 9, 2017
| if (mana >= 10) { | ||
| mana -= 10 | ||
| $mpBar.text(`${mana}/200`) | ||
| $mpBar.css('width', `${$mpBar.width() - 10}px`) |
There was a problem hiding this comment.
Why not make the position = $player.position().left ?
Author
There was a problem hiding this comment.
its to reduce the width of the blue bar as the mana is used up, doesn't have any link to player position
Siya-ng
reviewed
Oct 9, 2017
|
|
||
| </div> | ||
| <script src="https://code.jquery.com/jquery-3.2.1.min.js"></script> | ||
| <script src="./assets/js/testScript.js" charset="utf-8"></script> |
There was a problem hiding this comment.
Why not rename the testScript to script and remove the script.js since you dont need it.
Glow
Grow & Things to look out for
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.