Skip to content

Edited readme.md and uploaded Flow Chart#24

Open
subutai1175 wants to merge 34 commits into
wdi-sg:masterfrom
subutai1175:master
Open

Edited readme.md and uploaded Flow Chart#24
subutai1175 wants to merge 34 commits into
wdi-sg:masterfrom
subutai1175:master

Conversation

@subutai1175
Copy link
Copy Markdown

No description provided.

Comment thread assets/js/script.js

function randomColor () {
var col = colorArr[randomNum()]
return col
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may do this : return colorArr[randomNum()]

Comment thread assets/js/script.js
scoreObj.score += 10
scoreObj.scoreBoard.text(`Score : ${scoreObj.score}`)
// TODO: No Click? click = false
} else if (recArr[count - 1] != recArr[count - n]) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!==

Comment thread assets/js/script.js
audioCorrect()
scoreObj.score += 10
scoreObj.scoreBoard.text(`Score : ${scoreObj.score}`)
} else if (recCol[count - 1] != recCol[count - n]) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!==

Comment thread assets/js/script.js
// Random Number Generator
function randomNum () {
var index = Math.floor(Math.random() * 8)
return index
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may just return the value

Comment thread assets/js/script.js
}

function audioCorrect () {
return document.getElementById('audioCorrect').play()
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we do this with jQuery?

Comment thread assets/js/script.js
var recCol = []
var count = 0
var index = 0
var on = 0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it is a confusing name with .on(). You can try gameOn , gameStart .

Comment thread index.html
<div class="container">
<h1>Dual N Back Game Instructions</h1>

<h3>Each turn a random location and color will flash on the gameboard. The goal is to memorize the location and color 'n' turns back. Currently n = 1. If the location or color of current turn is the same as that of the previous turn, we should trigger the location or color button</h3><br>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why everything is h3 tags here?

Comment thread game.html
<body>
<audio id="audioCorrect" type="audio/mpeg" src="./audio/correctAnswer.mp3"></audio>
<audio id="audioWrong" type="audio/mpeg" src="./audio/wrongAnswer.mp3"></audio>
<div class="container">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation issues here

Comment thread assets/js/script.js
var index = 0
var on = 0
var refreshIntervalId
var n = 2 // Difficulty Setting
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why dont name this variable difficultyLevel instead?

Comment thread assets/js/script.js
gameOverDiv.css('display', 'none')
})
$colorBtn.on('click', compareColor)
$(document).on('keydown', function (e) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you give some spaces in between these codes? group them logically so it's easier to be read

@alexkimin
Copy link
Copy Markdown

alexkimin commented Oct 15, 2017

Project Workflow: 3 / 5
Technical Requirement: 3 / 5
Creativity: 3 / 5
Code Quality: 3 / 5
Problem Solving: 3 / 5

Glow

Scaling down on the idea.
Step by step approach for additional functionality.
Active on questioning.

Grow

Need more detailed commit message, not like 'second try'.
Naming convention for variables.

Things to look for

I know it is hard to be familiar with many methods. Just keep practicing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants