Skip to content

Commit

Permalink
Merge pull request #985 from opencfp/ch-prophecy-for-tests
Browse files Browse the repository at this point in the history
CONTRIBUTING update
  • Loading branch information
Dustin Wheeler authored Dec 18, 2017
2 parents 5ce0365 + 2a891ae commit 77574d1
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ We accept contributions via Pull Requests on [Github](https://github.com/opencfp

- **Tests must be clear in meaning** - We value clarity in meaning / purposes behind tests. If there is excessive setup required for a test, it should be hidden behind an intention-revealing (and possibly re-usable) method.

- **Tests doubles must use [Prophecy](https://phpunit.de/manual/current/en/test-doubles.html#test-doubles.prophecy)** - The project is migrating away from [Mockery](http://docs.mockery.io/en/latest/) to reduce dependencies

- **Document any change in behaviour** - Make sure the `README.md` and any other relevant documentation are kept up-to-date.

- **Create feature branches** - Feature branches are critically important if you're going to be sending us more than one contribution. Don't send a PR from `master`!
Expand Down

0 comments on commit 77574d1

Please sign in to comment.