Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FabricEngine Package #8817

Merged
merged 4 commits into from
Sep 30, 2023
Merged

Add FabricEngine Package #8817

merged 4 commits into from
Sep 30, 2023

Conversation

zamadatix
Copy link
Contributor

@zamadatix zamadatix commented Sep 14, 2023

Add FabricEngine package repository definition in f.json

  • I'm the package's author and/or maintainer.
  • I have have read [the docs][1].
  • I have tagged a release with a [semver][2] version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries.
  • My package doesn't add key bindings.
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme.
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use [.gitattributes][3] to exclude files from the package: images, test files, sublime-project/workspace.

My package is similar to some other switch config file syntax highlighting packages for other networking vendors but is unique in that it supports the specific syntax of the Extreme FabricEngine switch platform, which is incompatible with other syntax definitions.

Note: The repo name is more generic but overridden so the package name is set to just "FabricEngine" per the naming guidelines.

Add FabricEngine package repositository definition in f.json
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: FabricEngine
Results help

Packages added:
  - FabricEngine

Processing package "FabricEngine"
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: FabricEngine.sublime-syntax

@braver
Copy link
Collaborator

braver commented Sep 29, 2023

Please have a look at the Scope Naming and examples. Your main scope should probably be source.fabricengine (to enable features for source code, not plain text which would be enabled by text.fabricengine), and each other scope should end with .fabricengine to allow features to target your syntax specifically (e.g. variable.language.fabricengine.

Add language syntax label as well as a few others
Already in name
@zamadatix
Copy link
Contributor Author

Please have a look at the Scope Naming and examples. Your main scope should probably be source.fabricengine (to enable features for source code, not plain text which would be enabled by text.fabricengine), and each other scope should end with .fabricengine to allow features to target your syntax specifically (e.g. variable.language.fabricengine.

Thanks for the tip! I've cleaned that up a bit, hopefully it looks a bit more correct now.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: FabricEngine
Results help

Packages added:
  - FabricEngine

Processing package "FabricEngine"
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: FabricEngine.sublime-syntax

@braver braver merged commit a0bac70 into wbond:master Sep 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants