-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer WolframLanguage package to WolframResearch #8373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Packages modified:
- WolframLanguage
Yes, a transfer as such actually needs to be handled via a PR here anyway, Will isn't usually actively involved in the registry but does the tech stack behind the service. It would be preferable if @ViktorQvarfordt would agree to transfer the GitHub repository to your org. That would set up GitHub to redirect everyone to the repo at the new URL and that also effectively transfers the package control entry. Finally we would also merge this PR to update the URL in our repository. Failing that we would usually give @ViktorQvarfordt two weeks to object against transferring the package control entry via this PR. The mentions here start that count down, so let's check back in two weeks from now and decide how to resolve this. |
Note that since you've included an LSP Plugin in your code, that makes it compatible with ST4 and above so the minimum version needs to be updated. |
Actually, the code is even importing from the LSP package without catching the import error so it will just crash if the LSP package is not installed. So if the LSP part is optional then this needs to be handled differently. And if the LSP part is required then that should be stated in the readme (there is no way to make package depend on another one automatically). |
Thank you for taking a look at this! I do want to keep LSP optional, so I will add error handling for when LSP is not installed. |
I agree to this
…On Wed, 22 Sep 2021 at 21:16 Koen Lageveen ***@***.***> wrote:
Yes, a transfer as such actually needs to be handled via a PR here anyway,
Will isn't usually actively involved in the registry but does the tech
stack behind the service.
It would be preferable if @ViktorQvarfordt
<https://github.com/ViktorQvarfordt> would agree to transfer the GitHub
repository to you org <https://github.com/WolframResearch>. That would
set up GitHub to redirect everyone to the repo at the new URL and thereby
also effectively transfer the package control entry. Finally we would also
merge this PR to update the URL in our repository.
Failing that we would usually give @ViktorQvarfordt
<https://github.com/ViktorQvarfordt> two weeks to object against
transferring the package control entry via this PR. The mentions here start
that count down, so let's check back in two weeks from now and decide how
to resolve this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8373 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACUF2NDHOQ54YQP4VPDUH3UDITSNANCNFSM5ER37VZQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Oh, alright! @bostick let me know when you’re ready for me to hit that button. |
I pushed up a change to handle LSP not being installed, so I think that addresses the only concern. This is the first package that I have pushed to Package Control, so I'm not sure if I'm missing anything else. If this looks good to everyone else, then let's hit that button! |
It should also require a minimum ST build version of 4000, seeing as you’re using constructs from LSP that are only available since that version. |
On second thought, I guess the ImportError catch will take care of that. |
Note that I have plans to switch to the python 3.8 runtime when package control libraries can run in 3.8: sublimelsp/LSP#1389 when that happens, all helper packages must be upgraded to the py38 runtime as well. |
Correct, I'm only trying to support the latest version of LSP. If there are any errors at all, then there simply won't be any LSP support. |
Sounds good all around. If all of this works, tag that latest version and we're good to go. |
I added a I also moved the tag, so I believe everything is ready. |
Thanks! I see it is now pointed to the new repo. I was not thinking and I added |
Hi, I work for Wolfram Research and I am the developer for our official Sublime package.
I would like to transfer the WolframLanguage package from https://github.com/ViktorQvarfordt/Sublime-WolframLanguage to https://github.com/WolframResearch/Sublime-WolframLanguage, so I am opening this PR.
Here is a message I sent to [email protected] and CCed [email protected] on August 31, but I have not yet heard a reply.
Maybe transferring can be as easy as merging this PR?