Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer WolframLanguage package to WolframResearch #8373

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

bostick
Copy link
Contributor

@bostick bostick commented Sep 22, 2021

Hi, I work for Wolfram Research and I am the developer for our official Sublime package.

I would like to transfer the WolframLanguage package from https://github.com/ViktorQvarfordt/Sublime-WolframLanguage to https://github.com/WolframResearch/Sublime-WolframLanguage, so I am opening this PR.

Here is a message I sent to [email protected] and CCed [email protected] on August 31, but I have not yet heard a reply.

Hello,

I am the developer of the official Wolfram Language package for Sublime Text:

https://github.com/WolframResearch/Sublime-WolframLanguage

We (Wolfram Research) are interested in taking over the WolframLanguage package in Package Control:

https://packagecontrol.io/packages/WolframLanguage

and I'm not sure what the process is to achieve this. (or indeed if this is even possible!)

This is a fork of the original package from Viktor Qvarfordt:

https://github.com/ViktorQvarfordt/Sublime-WolframLanguage

You can see that there has not been any development for a couple of years.

Wolfram Research is interested in taking over ownership of this package and providing ongoing development and support.

We have been in communication with Viktor and he has agreed to transfer ownership to Wolfram Research.

Has Package Control dealt with kind of thing before?

What should be the next step?

Brenton

Maybe transferring can be as easy as merging this PR?

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - WolframLanguage

@braver
Copy link
Collaborator

braver commented Sep 22, 2021

Yes, a transfer as such actually needs to be handled via a PR here anyway, Will isn't usually actively involved in the registry but does the tech stack behind the service.

It would be preferable if @ViktorQvarfordt would agree to transfer the GitHub repository to your org. That would set up GitHub to redirect everyone to the repo at the new URL and that also effectively transfers the package control entry. Finally we would also merge this PR to update the URL in our repository.

Failing that we would usually give @ViktorQvarfordt two weeks to object against transferring the package control entry via this PR. The mentions here start that count down, so let's check back in two weeks from now and decide how to resolve this.

@braver braver added awaiting objection A package is being replaced or moved and awaits objection from a current maintainer feedback provided takeover Package maintainership is changing labels Sep 22, 2021
@rchl
Copy link
Contributor

rchl commented Sep 22, 2021

Note that since you've included an LSP Plugin in your code, that makes it compatible with ST4 and above so the minimum version needs to be updated.

@rchl
Copy link
Contributor

rchl commented Sep 22, 2021

Actually, the code is even importing from the LSP package without catching the import error so it will just crash if the LSP package is not installed.

So if the LSP part is optional then this needs to be handled differently. And if the LSP part is required then that should be stated in the readme (there is no way to make package depend on another one automatically).

@bostick
Copy link
Contributor Author

bostick commented Sep 22, 2021

Thank you for taking a look at this! I do want to keep LSP optional, so I will add error handling for when LSP is not installed.

@ViktorQvarfordt
Copy link
Contributor

ViktorQvarfordt commented Sep 22, 2021 via email

@braver
Copy link
Collaborator

braver commented Sep 22, 2021

Oh, alright! @bostick let me know when you’re ready for me to hit that button.

@bostick
Copy link
Contributor Author

bostick commented Sep 22, 2021

I pushed up a change to handle LSP not being installed, so I think that addresses the only concern.

This is the first package that I have pushed to Package Control, so I'm not sure if I'm missing anything else.

If this looks good to everyone else, then let's hit that button!

@rwols
Copy link
Contributor

rwols commented Sep 22, 2021

It should also require a minimum ST build version of 4000, seeing as you’re using constructs from LSP that are only available since that version.

@rwols
Copy link
Contributor

rwols commented Sep 22, 2021

On second thought, I guess the ImportError catch will take care of that.

@rwols
Copy link
Contributor

rwols commented Sep 22, 2021

Note that I have plans to switch to the python 3.8 runtime when package control libraries can run in 3.8: sublimelsp/LSP#1389

when that happens, all helper packages must be upgraded to the py38 runtime as well.

@bostick
Copy link
Contributor Author

bostick commented Sep 22, 2021

Correct, I'm only trying to support the latest version of LSP. If there are any errors at all, then there simply won't be any LSP support.

@braver
Copy link
Collaborator

braver commented Sep 23, 2021

Sounds good all around.
Just as a tiny tip/enhancement, you might want to make use of .gitattributes to exclude some files from the package archive to save some storage and data for users (e.g. docs and anything else that isn't part of the package functionality).

If all of this works, tag that latest version and we're good to go.

@bostick
Copy link
Contributor Author

bostick commented Sep 23, 2021

I added a .gitattributes file and all of the export-ignore entries that were needed. I did not know that Package Control used git archive to make releases. That is good to know.

I also moved the tag, so I believe everything is ready.

@braver braver merged commit ea6c6e4 into wbond:master Sep 23, 2021
@bostick
Copy link
Contributor Author

bostick commented Sep 23, 2021

Thanks!

I see it is now pointed to the new repo.

I was not thinking and I added messages.json export-ignore to .gitattributes. I did not get any messages when I installed the package, and I think that I should have left messages in the archive. I will fix that up in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting objection A package is being replaced or moved and awaits objection from a current maintainer feedback provided takeover Package maintainership is changing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants