Refactoring

[shah743]

No description provided.

[wazery]

Thanks for your PR, very much appreciated 😄

[sonalkr132]

I pulled @shah743 refactoring, it has lot of improvements but it introduced many new bugs too. For ex: Migration gives:

NameError: uninitialized constant CacheMigration

I changed CreateRatingCaches to CacheMigration (not sure if thats how things are suppose to be) in lib/generators/ratyrate/templates/cache_migration.rb file. Then it gave:

Index name 'index_rating_averages_on_rateable_id_and_rateable_type_and_rater_id' on table 'rating_averages' is too long; the limit is 62 characters

I just deleted that index from lib/generators/ratyrate/templates/rating_average_migration.rb.
I had used = rating_for_user @project, current_user, "stars" my app but staring it gives error:

NoMethodError - undefined method `qty=' for #RatingAverage:0x000000069150e0

Any clue what might be causing last error?

[sonalkr132]

I had used = rating_for_user @project, current_user, "stars" my app but staring it gives error:

NoMethodError - undefined method `qty=' for #RatingAverage:0x000000069150e0

Any clue what might be causing last error?

Issue is in lib/ratyrate/model.rb:

def update_overall_average_rating(stars, user, dimension)
    # We need user average rating for all dimensions as will as overall rating form all users of all dimensions ( which they have rated )
    user_average = average_rates_for_user(user) || average_rates_with_user.build(rater: user)
    user_average.avg = user.ratings_given.where(rateable: self).average(:stars)
    user_average.qty = user.ratings_given.where(rateable: self).count
    user_average.save validate: false

    overall     = average_rates || build_average_rates
    overall.avg = Rate.where(rateable: self).average(:stars)
    overall.qty = Rate.where(rateable: self).count
    overall.save validate: false
end

averate_rates don't have qty field in them. Do we need it? It works fine if we just remove those two line.