Fix node-compress compiling #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Also I noticed that after locally running Can you duplicate this and do we need to fix? Ty. |
|
Yeah, it should be |
add package.json and fix symlink
|
Will this pull request be merged or no? compress won't run with node 0.6 :( |
|
Is there anyway to use your fork @elliotttf to install a package that is dependent on compress? |
|
Yes @ecoffey-trada . You can use it like this Put this in your package.json "compress": "git+ssh://git://github.com/elliotttf/node-compress.git" |
|
Thanks @madhums :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the compress.cc code to handle the removal of node_events.h. I'm not 100% sure Iv'e done this correctly, but the test scripts seem to work.
FWIW, I found this post helpful: [http://permalink.gmane.org/gmane.comp.lang.javascript.nodejs/28298]