Node api finality #1897
Node api finality #1897
Conversation
pkg/wallet/stub.go
Outdated
| func (s Stub) SignTransactionWith(pk crypto.PublicKey, tx proto.Transaction) error { | ||
| panic("Stub.SignTransactionWith: Unsupported operation") | ||
| func (s Stub) SignTransactionWith(_ crypto.PublicKey, _ proto.Transaction) error { | ||
| panic("Stub.SignTransactionWith: Unsopported operation") |
There was a problem hiding this comment.
Does the word “unsOpported” exist?
pkg/wallet/embedded_wallet.go
Outdated
| return crypto.PublicKey{}, ErrPublicKeyNotFound | ||
| } | ||
|
|
||
| func (a *EmbeddedWalletImpl) BlsPairByWavesPK(publicKey crypto.PublicKey) (bls.SecretKey, bls.PublicKey, error) { |
There was a problem hiding this comment.
"Bls" should be "BLS".
pkg/state/commitments.go
Outdated
|
|
||
| // FindEndorserPKsByIndexes returns BLS endorser public keys using | ||
| // commitment indexes stored in FinalizationVoting.EndorserIndexes. | ||
| func (c *commitments) FindEndorserPKsByIndexes( |
There was a problem hiding this comment.
Why "PKs" and "indexes", not "PK" and "index", the function returns only one public key and accepts only one index.
pkg/state/finalization.go
Outdated
| "github.com/wavesplatform/gowaves/pkg/proto" | ||
| ) | ||
|
|
||
| const finalizationKey = "finalization" |
There was a problem hiding this comment.
All keys have to be introduced in
Line 139 in 8b0ac77
pkg/state/finalization.go
Outdated
| var ErrNoFinalizationHistory = errors.New("no finalization in history") | ||
|
|
||
| type finalizationItem struct { | ||
| Block proto.BlockHeader `cbor:"0,keyasint,omitempty"` |
There was a problem hiding this comment.
No need to store block header second time here, can be retrieved by height or blockID.
| func (fr *finalizationRecord) unmarshalBinary(data []byte) error { return cbor.Unmarshal(data, fr) } | ||
|
|
||
| type finalizations struct { | ||
| hs *historyStorage |
There was a problem hiding this comment.
As we discussed the finalization storage should not be a history storage. In case of using history the rollback will happen automatically, but the idea of finalization records that they are irreversible.
There was a problem hiding this comment.
The finalization now contains only one item, I kept the history storage. Moved it to the other PR
pkg/state/appender.go
Outdated
| return false, fmt.Errorf("failed to build endorsement message: %w", err) | ||
| } | ||
|
|
||
| // 2. Восстанавливаем endorser PK по индексам |
There was a problem hiding this comment.
Oh no! Please use English only.
pkg/state/appender.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func (a *txAppender) isLastBlockFinalized( |
There was a problem hiding this comment.
Strange naming, is it better to name the function "updateFinalization" or "calculateFinalization"?
pkg/state/appender.go
Outdated
| if err != nil { | ||
| return false, err | ||
| } | ||
| msg, err := proto.EndorsementMessage( |
There was a problem hiding this comment.
Why construct an endorsement message here?
There was a problem hiding this comment.
Ah, I see, it's for block header validation. I'd rather move this function to proto package, somewhere near block declaration or even made it a part of Block type.
There was a problem hiding this comment.
Which file are you suggesting to move it to?
There was a problem hiding this comment.
Because this function EndorsementMessage is already in proto
There was a problem hiding this comment.
Corresponding `pkg/client' parts have to be implemented.
|
Moved storage to add-network-messages |
No description provided.