Skip to content

Commit

Permalink
Merge pull request #148 from jabdoa2/helm_chart_improvements
Browse files Browse the repository at this point in the history
Helm chart improvements (PodDisruptionBudget and topologySpreadConstraints)
  • Loading branch information
toelke authored Apr 29, 2024
2 parents 2efae59 + bd3999d commit edc7542
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/wave/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: v1
apiVersion: v2
name: wave
description: wave chart that runs on kubernetes
version: 3.0.0
Expand Down
1 change: 1 addition & 0 deletions charts/wave/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,5 @@ spec:
nodeSelector: {{ toYaml .Values.nodeSelector | nindent 8 }}
affinity: {{ toYaml .Values.affinity | nindent 8 }}
tolerations: {{ toYaml .Values.tolerations | nindent 8 }}
topologySpreadConstraints: {{ toYaml .Values.topologySpreadConstraints | nindent 8 }}
volumes: {{ toYaml .Values.extraVolumes | nindent 8 }}
12 changes: 12 additions & 0 deletions charts/wave/templates/poddisruptionbudget.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{{- if .Values.pdb.enabled }}
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
name: {{ include "wave-fullname" . }}
namespace: {{ .Release.Namespace }}
spec:
selector:
matchLabels:
{{ include "wave.selectorLabels" . | nindent 6}}
maxUnavailable: 1
{{- end }}
10 changes: 10 additions & 0 deletions charts/wave/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ nodeSelector: {}
# Replicas > 1 will enable leader election
replicas: 1

# Add PodDisruptionBudget which should be enabled for replicas > 1
pdb:
enabled: false

# Additional volumes to use in the pod.
extraVolumes: []
# - name: tmp
Expand Down Expand Up @@ -58,8 +62,14 @@ resources: {}
# cpu: 100m
# memory: 128Mi

# node tolerations for wave pod
tolerations: []

# (anti-)affinity for wave pods
affinity: {}

# topologySpreadConstraints for the wave pods
topologySpreadConstraints: []

# extra annotations for wave pods
podAnnotations: {}

0 comments on commit edc7542

Please sign in to comment.