Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sort key for oshis #56

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add sort key for oshis #56

wants to merge 7 commits into from

Conversation

csm-kb
Copy link
Contributor

@csm-kb csm-kb commented Mar 3, 2025

Closes #32

@csm-kb csm-kb requested a review from DaniruKun March 3, 2025 03:27
@csm-kb csm-kb self-assigned this Mar 3, 2025
@csm-kb csm-kb linked an issue Mar 3, 2025 that may be closed by this pull request
Add sort key for oshis #32
Open
csm-kb
csm-kb commented Mar 3, 2025
View reviewed changes
supabase/migrations/20250302115105_add_talents_sort_key.sql
WITH debut_order AS (
SELECT gen, sort_order FROM (
VALUES
-- Hololive: JP
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this tabbing looks weird because GitHub doesn't render it the aligned way you see it in VS Code... ignore!

@csm-kb csm-kb marked this pull request as ready for review March 3, 2025 03:31
@DaniruKun
Copy link
Member

Hmm I tried running the branch locally, but it fails in the PassCard component with:

PassCard.svelte:73 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'length')

	in PassCard.svelte
	in +page.svelte
	in layout.svelte
	in +layout.svelte
	in root.svelte

    at PassCard.svelte:73:17
    at PassCard.svelte:78:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniruKun DaniruKun Awaiting requested review from DaniruKun

Assignees

@csm-kb csm-kb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add sort key for oshis
2 participants
@csm-kb @DaniruKun