Fix: drag n drop like trello in example #785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is sample demo. trello.webmI see no recent activity on the issue, so I gave it a shot. Let me know if this looks good. @matijaSos |
matijaSos
approved these changes
Oct 27, 2022
examples/waspello/ext/MainPage.js
Outdated
| @@ -187,6 +191,11 @@ const List = ({ list, index, cards }) => { | |||
| setIsPopoverOpen(false) | |||
| } | |||
|
|
|||
| const handleHeadingClick = (e) => { | |||
There was a problem hiding this comment.
Suggested change
| const handleHeadingClick = (e) => { | |
| const handleHeadingClicked = (e) => { |
We usually write handlers in passive (e.g. "handleButtonPressed"), so just to keep it standardized across the codebase.
examples/waspello/ext/MainPage.js
Outdated
| @@ -169,12 +169,16 @@ const Lists = ({ lists, listIdToCardsMap }) => { | |||
|
|
|||
| const List = ({ list, index, cards }) => { | |||
| const [isPopoverOpen, setIsPopoverOpen] = useState(false) | |||
| const [showHeaderTarget, setShowHeaderTarget] = useState(true); | |||
There was a problem hiding this comment.
Suggested change
| const [showHeaderTarget, setShowHeaderTarget] = useState(true); | |
| const [isHeaderTargetShown, setIsHeaderTargetShown] = useState(true); |
We usually start boolean values with is, so tried to rewrite it to follow this rule.
|
I have updated the code as per comments |
Awesome, will merge today! |
|
@anup-a merged! Thanks again for your help, really cool that you fixed this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change will allow drag n drop like Trello. I did a deep dive into Trello's code, and tried to mimic the feature in same exact manner.
Fixes #338
Type of change
Please select the option(s) that is more relevant.