Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapting Prisma for the new structure #1604

Merged
merged 57 commits into from
Jan 29, 2024

Conversation

sodic
Copy link
Contributor

@sodic sodic commented Dec 19, 2023

Fixes #1596

Tasks:

  • Modify the generator to list prisma as a dependency in the project's package.json file.
  • Decide where to list the @prisma/client dependency. - I put it in SDK and everything seems to work OK.
  • Verify all Prisma operations successfully execute at the project's top level.
  • Verify everything's OK with the types and the IDE support. - Check this again when generating the SDK code using the generator.
  • Verify everything builds properly

How to run and test stuff:

  • Go to waspc/examples/todo-typescript and work inside that project.
  • Running ./cleanstart will clean everything, fix known issues (e.g., duplicate react) and start the app with all the necessary migrations applied.
  • The rest of the commands (e.g,. cabal run wasp-cli start, cabal run wasp-cli clean) will do what you expect.
  • After each change, either let the application pick it up, rerun cabal run wasp-cli start, or run ./cleanstart (depending on what you're changing).
  • You can run ./fix to fix the double react installation issue (but often won't need to, as ./cleanstart takes care of it).
  • Please don't commit the migrations or package-lock.json.

Important

PR 1603 (filip-wasp-reset) branches out of PR 1604 (filip-restructuring-prisma), which branches out of PR 1602 (filip-project-install-step).
The PR numbers are unfortunately out of order.
Make sure you keep the branches up to date with their bases as you change stuff.

@Martinsos
Copy link
Member

Martinsos commented Jan 18, 2024

Fixed the comments, didn't try running anything yet to see if everything works fine tried running it, everything seems to work fine!

Base automatically changed from filip-project-install-step to filip-restructuring-prototype January 29, 2024 13:43
@sodic sodic changed the base branch from filip-restructuring-prototype to filip-restructuring January 29, 2024 13:45
@sodic sodic changed the base branch from filip-restructuring to backup-filip-project-install-step January 29, 2024 13:46
@sodic sodic marked this pull request as ready for review January 29, 2024 13:46
@sodic sodic changed the base branch from backup-filip-project-install-step to filip-restructuring January 29, 2024 13:57
@sodic sodic merged commit df5a135 into filip-restructuring Jan 29, 2024
1 of 4 checks passed
@sodic sodic deleted the filip-restructuring-prisma branch January 29, 2024 14:10
@sodic sodic mentioned this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants