Adapt the wasp clean command and fix dep installation
#1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolved/fixed all the comments. |
Base automatically changed from
filip-restructuring-prisma
to
filip-restructuring
January 29, 2024 14:10
sodic
changed the title
wasp clean commandwasp clean command and fix dep installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new command that deletes all Wasp's build artifacts in the new structure:
.waspdirectory.node_modulesdirectory.We can discuss whether this command is really necessary for users. I think it's useful for us. I initially implemented it to have an easier time testing stuff, and we'll often want to clean all build artifacts when working on Wasp.
We can also discuss the name of the command, and whether we should update the
cleancommand to do this instead of having two commands.How to run and test stuff:
waspc/examples/todo-typescriptand work inside that project../cleanstartwill clean everything, fix known issues (e.g., duplicate react) and start the app with all the necessary migrations applied.cabal run wasp-cli start,cabal run wasp-cli clean) will do what you expect.cabal run wasp-cli start, or run./cleanstart(depending on what you're changing)../fixto fix the double react installation issue (but often won't need to, as./cleanstarttakes care of it).package-lock.json.Important
PR 1603 (
filip-wasp-reset) branches out of PR 1604 (filip-restructuring-prisma), which branches out of PR 1602 (filip-project-install-step).The PR numbers are unfortunately out of order.
Make sure you keep the branches up to date with their bases as you change stuff.