Skip to content

Update to wasm-tools v229 #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Update to wasm-tools v229 #1501

wants to merge 24 commits into from

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented May 5, 2025 •
edited
Loading

No description provided.

Robbepop added 16 commits May 5, 2025 12:04
@Robbepop
bump wasm-tools dependencies to v229
cf75f95
@Robbepop
fix some compile errors after the update
8e43ed1
@Robbepop
restructure buffered Module parsing
5f2eae4 
This way we no longer parse certain sections (such as the data section) twice which is now an error in the new wasmparser v0.229 since the parser now includes malformedness checks.

We have to perform a similar restructuring for the streamed parsing as well.
@Robbepop
merge parse_buffered_impl and parse_buffered_header
5754704
@Robbepop
move utility methods to the bottom of the file
795a7cd
@Robbepop
simplify buffered parsing code
2366264
@Robbepop
remove consume_buffer utility method
929143e
@Robbepop
set wasmparser::Parser WasmFeatures properly
85d150d
@Robbepop
refactor next_payload code
fc5e51d
@Robbepop
refactor and clean-up buffered module parsing
9166388
@Robbepop
move ModuleParser::finish to parser.rs
63f0b4d
@Robbepop
apply rustfmt
ecd7ec2
@Robbepop
update Module::new_streaming impl to work with the new wasmparser
f49fc18
@Robbepop
remove Deref[Mut] impls from ParseBuffer
c6a316e
@Robbepop
apply rustfmt
34c9aa6
@Robbepop
use self method calling style for ParseBuffer
e75dc59
@codecov Codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.59091% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.76%. Comparing base (50ac767) to head (d5c2418).

Files with missing lines Patch % Lines
crates/wasmi/src/module/parser/streaming.rs 96.29% 2 Missing ⚠️
crates/wasmi/src/module/parser/buffered.rs 96.29% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1501      +/-   ##
==========================================
+ Coverage   70.72%   70.76%   +0.03%     
==========================================
  Files         176      176              
  Lines       16575    16584       +9     
==========================================
+ Hits        11723    11736      +13     
+ Misses       4852     4848       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Robbepop Robbepop mentioned this pull request May 6, 2025
Open
@Robbepop
Copy link
Member Author

Robbepop commented May 6, 2025 •
edited
Loading

Due to the massive performance regressions between wasmparser v228 -> v229 I decided not to update to wasm-tools v229 for the upcoming Wasmi v0.45.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Robbepop