Added par support to wash-lib #844
Conversation
aish-where-ya
requested review from
autodidaddict,
brooksmtownsend and
thomastaylor312
as code owners
There was a problem hiding this comment.
One nit, one comment that may not be applicable anymore, but mostly ergonomic changes that feel like they would make the functions here a whole lot simpler if we pushed a little responsibility on the CLI-side. Essentially, I think finding and loading keypairs and files should be the responsibility of the CLI, and the library can just properly take that information and turn it into the appropriate ProviderArchive structs that the CLI can then write out
Signed-off-by: aish-where-ya <[email protected]>
Signed-off-by: aish-where-ya <[email protected]>
aish-where-ya
force-pushed
the
chore/par-washlib
branch
from
9e73a10 to
1b95d9c
Compare
|
I think I managed to address all the review comments here. Pulling stuff out from the library into the CLI definitely helped in reducing some of the function arguments and also removing the function argument struct for the |
crates/wash-lib/src/cli/par.rs
Outdated
| Ok(par) | ||
| } | ||
|
|
||
| pub async fn insert_provider_archive( |
There was a problem hiding this comment.
I think this should be named insert_provider_binary to be specific
Signed-off-by: aish-where-ya <[email protected]>
Feature or Problem
Feat: Move
wash partowash-libRelease Information
next
Consumer Impact
Internal code refactoring.
No impact to existing functionality
Testing
unit and manual tests
Built on platform(s)
Tested on platform(s)
Unit Test(s)
NA
Acceptance or Integration
NA
Manual Verification
manually verified