Repository navigation
build(deps): migrate to @wasmer/sdk 0.19.0 #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TakalaWang
wants to merge
7
commits into
wasm-oj:main
Choose a base branch
from
TakalaWang:feat/wasmer-sdk-0.19
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,765
−4,888
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b70e256
feat(runner): read package command modules from WEBC atoms
TakalaWang 755891e
build(deps): migrate compilers and runtime preparation to @wasmer/sdk…
TakalaWang 0e820a2
chore(licenses): record @wasmer/sdk 0.19.0 license material
TakalaWang 89934f0
test(server): stress cancellation of compiler, preparation and runner…
TakalaWang 515646f
docs: describe the @wasmer/sdk 0.19.0 integration
TakalaWang 087070e
perf(server): reuse compiler stage children across builds
TakalaWang c247794
docs: describe reusable server compiler children
TakalaWang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,31 @@ All notable changes to WASM-OJ are recorded here. Releases follow | |
| [Semantic Versioning](https://semver.org/) and the contract/package versioning policy in | ||
| [the versioning policy](docs/versioning.md). | ||
|
|
||
| ## Unreleased | ||
|
|
||
| - Upgraded `@wasmer/sdk` from 0.10.0 to 0.19.0. Clang, rustc, TypeScript, and Python | ||
| runtime-file preparation now run to exit in per-build SDK sandboxes, which removes the | ||
| 0.10.0 race that could leave a finished process waiting forever for output EOF and stall | ||
| Python preparation or TypeScript compilation under load. Compiled artifacts are unchanged. | ||
| - The server compiler child and its rustc stage serve sequential builds and keep their loaded | ||
| toolchain packages, so the SDK's package load is paid once per child instead of once per build. | ||
| Cancellation, timeout, or failure discards the child; an idle child exits after 30 s, and either | ||
| child exits when its parent goes away. The rustc stage is replaced after the browser's stage | ||
| budget (two builds). | ||
| - `@wasm-oj/browser` ships the SDK's browser runtime files unbundled under | ||
| `assets/wasmer-sdk-<digest>/` and no longer installs `@wasmer/sdk`. Hosts that copy the | ||
| package's `dist/assets/` must copy that directory recursively. The SDK's WISP networking | ||
| module is not shipped, and its host-function trampoline is built without `eval`, so | ||
| execution still works under a strict Content Security Policy. | ||
| - Python execution reads the interpreter module directly from the pinned WEBC package and | ||
| verifies its digest. | ||
| - Raw Clang output names `/workspace/...` instead of `/project/...` source paths. Parsed | ||
| diagnostics and emitted artifacts are unchanged. | ||
| - The runtime identity changes with the SDK, so artifacts cached by earlier releases are | ||
| rebuilt. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: hosts with a persistent artifact cache get one failed compile before the rebuild.
Fix, either:
|
||
| - `@wasmer/sdk` 0.19.0 is distributed under Wasmer's Modified MIT License, which adds an | ||
| attribution condition for large commercial deployments; see `THIRD_PARTY_NOTICES.md`. | ||
|
|
||
| ## 0.2.3 - 2026-10-05 | ||
|
|
||
| - Download pinned browser toolchain assets before the compiler timeout starts, so slow | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| Modified MIT License | ||
|
|
||
| Copyright (c) 2026 Wasmer, Inc. | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the “Software”), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. | ||
|
|
||
| Our only modification part is that, if the Software (or any derivative works | ||
| thereof) is used for any of your commercial products or services that have | ||
| more than 1 million monthly active users, or more than 1 million US dollars | ||
| (or equivalent in other currencies) in monthly revenue, you shall prominently | ||
| display "Wasmer" on the user interface of such product or service. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: this doesn't hold for link errors.
stderr.trim().wasm-ld: error: /project/build/0000.o: undefined symbol: missingbecomes…/workspace/build/0000.o….ServerCompileroutput on main and on this PR, and in Chromium on the PR build.Fix, either:
/workspace/..."./workspace/back to/project/in the failure message.