fix: recognize void keywords in member fn results #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vados-cosmonic
force-pushed
the
fix=recognize-void-keyword-as-member-fn-result
branch
from
694853a to
35ca8fe
Compare
|
@vados-cosmonic do you have any examples of WebIDL using void? See https://webidl.spec.whatwg.org/#idl-undefined, seems like void is no longer allowed.
|
|
Yeah I had one actually in the tests -- do we want to just remove that? Can we make the parser any stricter to avoid allowing |
|
If we wanna keep closest to the spec, we should probably allow types that are named |
|
If all you want is for the test to clear, than I think changing void to undefined is the right thing here. |
|
Hey thanks for the note here -- I'll change the tests, and use [EDIT] - I can actually just completely remove |
Signed-off-by: Victor Adossi <[email protected]>
vados-cosmonic
force-pushed
the
fix=recognize-void-keyword-as-member-fn-result
branch
from
35ca8fe to
8e58c09
Compare
Signed-off-by: Victor Adossi <[email protected]>
vados-cosmonic
deleted the
fix=recognize-void-keyword-as-member-fn-result
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where
voidcould be a return type in member functions (ex. in an Interface) and was being recognized as a type.This leads to WIT thinking that
voidis a type that should have been defined elsewhere