Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ws from 7.5.9 to 7.5.10 in /LogViewer.Client #955

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
+6 −6
Open

Bump ws from 7.5.9 to 7.5.10 in /LogViewer.Client #955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions LogViewer.Client/package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Unchanged files with check annotations Beta

View file
LogViewer.Server/Models/LogResults.cs
{
public class LogResults
{
public PagedResult<LogMessage> Logs { get; set; }

Check warning on line 7 in LogViewer.Server/Models/LogResults.cs

GitHub Actions / CodeQL-Build 

Non-nullable property 'Logs' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

Check warning on line 7 in LogViewer.Server/Models/LogResults.cs

GitHub Actions / CodeQL-Build 

Non-nullable property 'Logs' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

Check warning on line 7 in LogViewer.Server/Models/LogResults.cs

GitHub Actions / .NET Core CLV Server exe Tests 

Non-nullable property 'Logs' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

Check warning on line 7 in LogViewer.Server/Models/LogResults.cs

GitHub Actions / Build Windows Apps 

Non-nullable property 'Logs' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
public List<LogTemplate> MessageTemplates { get; set; }

Check warning on line 9 in LogViewer.Server/Models/LogResults.cs

GitHub Actions / CodeQL-Build 

Non-nullable property 'MessageTemplates' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

Check warning on line 9 in LogViewer.Server/Models/LogResults.cs

GitHub Actions / CodeQL-Build 

Non-nullable property 'MessageTemplates' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

Check warning on line 9 in LogViewer.Server/Models/LogResults.cs

GitHub Actions / .NET Core CLV Server exe Tests 

Non-nullable property 'MessageTemplates' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

Check warning on line 9 in LogViewer.Server/Models/LogResults.cs

GitHub Actions / Build Windows Apps 

Non-nullable property 'MessageTemplates' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
}
}
View file
LogViewer.Server/Parser/LogParser.cs
LogFilePath = filePath;
LogIsOpen = true;
FileWatcher.Path = Path.GetDirectoryName(LogFilePath);

Check warning on line 72 in LogViewer.Server/Parser/LogParser.cs

GitHub Actions / CodeQL-Build 

Possible null reference assignment.

Check warning on line 72 in LogViewer.Server/Parser/LogParser.cs

GitHub Actions / CodeQL-Build 

Possible null reference assignment.

Check warning on line 72 in LogViewer.Server/Parser/LogParser.cs

GitHub Actions / .NET Core CLV Server exe Tests 

Possible null reference assignment.

Check warning on line 72 in LogViewer.Server/Parser/LogParser.cs

GitHub Actions / Build Windows Apps 

Possible null reference assignment.
FileWatcher.Filter = Path.GetFileName(LogFilePath);
FileWatcher.EnableRaisingEvents = true;
FileWatcher.Changed += async (sender, args) =>

Check warning on line 77 in LogViewer.Server/Parser/LogParser.cs

GitHub Actions / CodeQL-Build 

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 77 in LogViewer.Server/Parser/LogParser.cs

GitHub Actions / CodeQL-Build 

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 77 in LogViewer.Server/Parser/LogParser.cs

GitHub Actions / .NET Core CLV Server exe Tests 

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 77 in LogViewer.Server/Parser/LogParser.cs

GitHub Actions / Build Windows Apps 

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
{
// Notify user that new entries has occured
// We don't pass back the new log lines, but rather just notify the client that new lines has been added
//await Clients.All.SendAsync("NotifyNewLogEntries");
_hubContext.Clients.All.SendAsync("NotifyNewLogEntries");

Check warning on line 82 in LogViewer.Server/Parser/LogParser.cs

GitHub Actions / CodeQL-Build 

Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.

Check warning on line 82 in LogViewer.Server/Parser/LogParser.cs

GitHub Actions / CodeQL-Build 

Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.

Check warning on line 82 in LogViewer.Server/Parser/LogParser.cs

GitHub Actions / .NET Core CLV Server exe Tests 

Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.

Check warning on line 82 in LogViewer.Server/Parser/LogParser.cs

GitHub Actions / Build Windows Apps 

Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.
};
return _logItems;