Update CMakeLists.txt #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boost_thread-mt will not be built, so there will be mistake when link the static library. Using boost_thread, it will be ok.
|
I used to write CMakeLists.txt file as you did, but on some systems the boost libraries are multithreading versions and has have suffix "mt". The best solution would be being able to detect boost libraries. However, I have no idea how to do this with CMake. A back-off could be instructing users to build boost by themselves in the README.md file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boost_thread-mt will not be built, so there will be mistake when link the static library. Using boost_thread, it will be ok.