Skip to content

feat: allow edit empty task from gantt panel #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jrainlau
Copy link

Jietu20250212-162315-HD.mp4

Edit empty task from gantt panel

PS: Could this repo turn on the ISSUE feature?

@sergioisidoro
Copy link

I was exploring this repo and your PR caught my eye. This is a nice feature, but I think it creates quite a big breaking change by changing the signature of the handleEditTask prop.

Why not accept a TaskOrEmpty in the arg of that function prop, making the transition much easier? I changed EditableTaskInfo to TaskOrEmpty with just a few changes and everything worked :) Still a breaking change, but a more gradual one.

Also note that you commited the packageManager and locked the vite plugin react to a tencent mirror (perhaps your org DNS is resolving to the mirror rather than the npm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants