Skip to content

msteams: maxRetryWait param to control waiting after 429 responses - #235

Merged
benbroadaway merged 4 commits into
masterfrom
bb/msteams-max-retry-wait
Aug 24, 2026
Merged

benbroadaway merged 4 commits into
masterfrom
bb/msteams-max-retry-wait

Conversation

@benbroadaway

Copy link
Copy Markdown
Collaborator

MS Graph API may return relatively huge durations to wait after a 429 response (e.g. 600 seconds) which may be far longer than reasonable for a process to sleep before a retry. If the response-given Retry-After is higher than the maxRetryWait param, then the task call ends with an exception (or silently ends if ignoreErrors is true).

  • Add input parameter maxRetryWait to control when to give up retrying instead of waiting for a rate limit reset
    • Default value is 30000ms (30s)
  • Mock sleep calls in tests to shave of a few seconds

@benbroadaway
benbroadaway requested a review from a team March 24, 2026 21:57
ibodrov
ibodrov previously approved these changes Apr 30, 2026

@ibodrov ibodrov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit

@benbroadaway
benbroadaway requested a review from a team August 24, 2026 18:48
@benbroadaway
benbroadaway merged commit d784b81 into master Aug 24, 2026
3 checks passed
@benbroadaway
benbroadaway deleted the bb/msteams-max-retry-wait branch August 24, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants