Skip to content

Conversation

@himself65
Copy link
Member

@himself65 himself65 commented Aug 1, 2025

Fixes: #1569

@vercel
Copy link

vercel bot commented Aug 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Aug 4, 2025 4:49pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 1, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 1, 2025

Open in StackBlitz

npm i https://pkg.pr.new/wakujs/waku@1576

commit: 61a2456

@himself65 himself65 force-pushed the himself65/2025/08/01/allow-server branch from 732c577 to b65e7bb Compare August 2, 2025 02:29
@himself65 himself65 force-pushed the himself65/2025/08/01/allow-server branch 3 times, most recently from fb53e57 to e1fc854 Compare August 4, 2025 10:38
@himself65 himself65 changed the title fix: allow read private folder during rsc feat: allow read private folder during rsc Aug 4, 2025
@himself65 himself65 marked this pull request as ready for review August 4, 2025 10:38
@himself65 himself65 requested a review from dai-shi August 4, 2025 10:38
Comment on lines 20 to 22
if (this.environment.name === 'rsc') {
return;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work anyways. So, I think we should remove it to avoid confusion.

@dai-shi dai-shi mentioned this pull request Aug 2, 2025
@dai-shi dai-shi added this pull request to the merge queue Aug 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 5, 2025
@dai-shi dai-shi added this pull request to the merge queue Aug 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 5, 2025
@dai-shi dai-shi merged commit 6046a08 into wakujs:main Aug 5, 2025
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow read private folder during RSC period (or custom period)

2 participants