Skip to content

test: remove redundant tests #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

test: remove redundant tests #1495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 35 additions & 35 deletions e2e/broken-links.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ test.describe(`broken-links: normal server`, async () => {
});

test.describe('broken-links: static server', () => {
test.skip(({ mode }) => mode !== 'PRD');

let port: number;
let stopApp: () => Promise<void>;
test.beforeAll(async () => {
Expand Down Expand Up @@ -137,43 +139,41 @@ test.describe('broken-links: static server', () => {
});
});

for (const mode of ['DEV', 'PRD'] as const) {
test.describe(`broken-links/dynamic-not-found: ${mode}`, async () => {
let port: number;
let stopApp: () => Promise<void>;
test.beforeAll(async () => {
({ port, stopApp } = await startApp(mode));
});
test.afterAll(async () => {
await stopApp();
});
test.describe(`broken-links/dynamic-not-found`, async () => {
let port: number;
let stopApp: () => Promise<void>;
test.beforeAll(async ({ mode }) => {
({ port, stopApp } = await startApp(mode));
});
test.afterAll(async () => {
await stopApp();
});

test('access sync page directly', async ({ page }) => {
await page.goto(`http://localhost:${port}/dynamic-not-found/sync`);
await expect(page.getByRole('heading')).toHaveText('Custom not found');
await expect(page).toHaveTitle('Custom Not Found Title');
});
test('access sync page directly', async ({ page }) => {
await page.goto(`http://localhost:${port}/dynamic-not-found/sync`);
await expect(page.getByRole('heading')).toHaveText('Custom not found');
await expect(page).toHaveTitle('Custom Not Found Title');
});

test('access async page directly', async ({ page }) => {
await page.goto(`http://localhost:${port}/dynamic-not-found/async`);
await expect(page.getByRole('heading')).toHaveText('Custom not found');
await expect(page).toHaveTitle('Custom Not Found Title');
});
test('access async page directly', async ({ page }) => {
await page.goto(`http://localhost:${port}/dynamic-not-found/async`);
await expect(page.getByRole('heading')).toHaveText('Custom not found');
await expect(page).toHaveTitle('Custom Not Found Title');
});

test('access sync page with client navigation', async ({ page }) => {
await page.goto(`http://localhost:${port}/`);
await expect(page.getByRole('heading')).toHaveText('Index');
await page.click("a[href='/dynamic-not-found/sync']");
await expect(page.getByRole('heading')).toHaveText('Custom not found');
await expect(page).toHaveTitle('Custom Not Found Title');
});
test('access sync page with client navigation', async ({ page }) => {
await page.goto(`http://localhost:${port}/`);
await expect(page.getByRole('heading')).toHaveText('Index');
await page.click("a[href='/dynamic-not-found/sync']");
await expect(page.getByRole('heading')).toHaveText('Custom not found');
await expect(page).toHaveTitle('Custom Not Found Title');
});

test('access async page with client navigation', async ({ page }) => {
await page.goto(`http://localhost:${port}/`);
await expect(page.getByRole('heading')).toHaveText('Index');
await page.click("a[href='/dynamic-not-found/async']");
await expect(page.getByRole('heading')).toHaveText('Custom not found');
await expect(page).toHaveTitle('Custom Not Found Title');
});
test('access async page with client navigation', async ({ page }) => {
await page.goto(`http://localhost:${port}/`);
await expect(page.getByRole('heading')).toHaveText('Index');
await page.click("a[href='/dynamic-not-found/async']");
await expect(page.getByRole('heading')).toHaveText('Custom not found');
await expect(page).toHaveTitle('Custom Not Found Title');
});
}
});
Loading