Skip to content

test: ensure server function is async #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

test: ensure server function is async #1494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/fixtures/fs-router/src/functions/say-hello.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import { SayHello } from '../components/say-hello.js';

export function sayHello() {
export async function sayHello() {
const promise = new Promise<string>((resolve) =>
setTimeout(() => resolve('React'), 1000),
);
Expand Down
1 change: 0 additions & 1 deletion e2e/fixtures/rsc-basic/modules/ai/src/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
'use server';
Copy link
Member

@dai-shi dai-shi Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, comparing with https://app.unpkg.com/[email protected]/files/rsc/dist/rsc-server.mjs

@himself65 Can you confirm?

Copy link
Member

@himself65 himself65 Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it's okay. I think I added this because we cant detect correctly before

import { InternalProvider } from './shared.js';
import { jsx } from 'react/jsx-runtime';

Expand Down
Loading