Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: e2e pnpm-workspace.yaml file #1130

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

rmarscher
Copy link
Collaborator

Sorry... I missed adding this file in #1079.

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
waku ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 3:29am

Copy link

codesandbox-ci bot commented Jan 7, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@rmarscher
Copy link
Collaborator Author

Although... is it not needed if the pnpm monorepo test was already passing?

@dai-shi
Copy link
Member

dai-shi commented Jan 7, 2025

Although... is it not needed if the pnpm monorepo test was already passing?

I have no idea... @himself65 ?

@tylersayshi
Copy link
Member

seems necessay: https://arc.net/l/quote/gqgjnbsw

@dai-shi
Copy link
Member

dai-shi commented Jan 7, 2025

Fair point. It's pnpm specific, but let's add it.

@dai-shi dai-shi merged commit 37f114f into wakujs:main Jan 7, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants