fix: filter network change #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (14)
|
1 task
kaichaosun
reviewed
Dec 24, 2024
chaitanyaprem
force-pushed
the
fix/filter-network-change
branch
7 times, most recently
from
2dd4165 to
a49ea9c
Compare
chaitanyaprem
force-pushed
the
fix/filter-network-change
branch
6 times, most recently
from
9c3a460 to
ce98bbc
Compare
kaichaosun
reviewed
Jan 3, 2025
chaitanyaprem
force-pushed
the
fix/filter-network-change
branch
from
ce98bbc to
f835818
Compare
kaichaosun
approved these changes
Jan 3, 2025
chaitanyaprem
force-pushed
the
fix/filter-network-change
branch
from
f835818 to
3f29eb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If there is a network type change i.e from wifi to 4G even if it involves an intermediary transition to offline, then unsubscribe and resubscribe all filters.
This is to avoid filter-push issue noticed as per https://discord.com/channels/1110799176264056863/1111541184490393691/1318842541436829717.