siksha-server-dev 팀에 대하여 cronjob 수동 실행 권한 부여 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onjob 수동 실행 권한 부여
|
글구 repo write 권한 없어서 fork repo 로 PR 날리신 거 같아서 권한 추가해드렸어요! |
davin111
reviewed
Nov 14, 2024
charts/argocd/values.yaml
Outdated
Comment on lines
79
to
80
| p, role:siksha-server-data, jobs, create, default/siksha-crawler, allow | ||
| p, role:siksha-server-data, jobs, create, default/siksha-crawler-dev, allow |
There was a problem hiding this comment.
jobs 라인은 별도로 필요 없을 거 같습니다. 이미 요게 없어도 cronjob 에서 job 실행시키는 권한이 동작하는 게 확인된 거 같아서요.
|
참고로, values.yaml 에 있는 건 Merge 한다고 반영되는 건 아니고, helm upgrade 를 직접 해줘야합니다. 이번엔 제가 적용해둘게요.
|
davin111
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
목적
siksha-crawler{-dev}에 정의되어 있는 cronjob을 수동으로 실행시킬 수 있도록 하기 위한 권한 추가고려사항
Reference