빈자리 알림 로직 추가 #110
Merged
빈자리 알림 로직 추가 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hank-Choi
requested review from
davin111,
Jhvictor4 and
subeenpark-io
and removed request for
a team
davin111
reviewed
Jul 6, 2023
| override suspend fun deleteVacancyNotification(id: String) { | ||
| vacancyNotificationRepository.deleteById(id) | ||
| override suspend fun deleteAll() { | ||
| vacancyNotificationRepository.deleteAll() |
There was a problem hiding this comment.
사실 데이터가 많다면 컬렉션 삭제, 재생성하고 인덱스 재생성하면 더 빠를텐데 DDL날리는것도 좀 그렇고 걍 써도 될듯
| path = "/v1/vacancy-notifications/lectures", method = [RequestMethod.GET], produces = [MediaType.APPLICATION_JSON_VALUE], | ||
| operation = Operation( | ||
| operationId = "getVacancyNotificationLectures", | ||
| responses = [ApiResponse(responseCode = "200", content = [Content(array = ArraySchema(schema = Schema(implementation = Lecture::class)))])] |
There was a problem hiding this comment.
우리 지난 번에 얘기한 건데 #70 (comment)
db entity 를 그대로 응답에 반환하지 않고 변환해서 전달하면 좋을 거 같아.
There was a problem hiding this comment.
이거 안그래도 반영중이었음
너무 리뷰가 빨랐음ㅋㅋㅋ
Hank-Choi
force-pushed
the
feature/vacancyNotiFix
branch
from
2a11d0a to
fa7893c
Compare
davin111
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경사항