Prevent navigable being overridden by parent navigable #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whimboo
added
bug
OrKoN
approved these changes
Jan 21, 2025
|
Interesting that the build and deploy tasks fail now. It is caused by code that landed long long ago. I'm going to open another PR with those fixes. |
I opened a PR #864 There is a new bikeshed version with stricter validation. |
whimboo
force-pushed
the
parent-navigable
branch
from
b9eff93 to
c97bf89
Compare
github-actions bot
added a commit
that referenced
this pull request
Jan 21, 2025
SHA: a4615b3 Reason: push, by whimboo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within
get the navigable infowe are overriding the passed innavigablewhen trying to get the navigable id of the parent navigable. Further steps in this method will then base on the parent instead of the current navigable.