Propose "instead of" in terms of media type #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OR13
commented
Jan 20, 2023
| @@ -519,12 +519,14 @@ <h6>JWT Decoding</h6> | |||
| </section> | |||
| </section> | |||
|
|
|||
| <section id="version-1.1"> | |||
| <h2>Version 1.1</h2> | |||
There was a problem hiding this comment.
added a section so we can distinguish between production rules for 1.1 and potential production rules for future versions
OR13
commented
Jan 20, 2023
| <section id="production"> | ||
| <h2>Production</h2> | ||
|
|
||
| <p> | ||
| This section describes how to produce a VC-JWT encoded | ||
| <code>VerifiableCredential</code> from a <code>Credential</code>. | ||
| <code>VerifiableCredential</code> from an object of media type <code>application/credential+ld+json</code>. |
There was a problem hiding this comment.
replace ambiguous "Credential" with specific media type, this change is potentially blocked by w3c/vc-data-model#1014
If that PR changes substantially, this PR will need to be rejected / reworked.
OR13
commented
Jan 20, 2023
TallTed
reviewed
Jan 20, 2023
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
selfissued
approved these changes
Jan 27, 2023
sbutterfield
approved these changes
Jan 27, 2023
mprorock
approved these changes
Jan 27, 2023
decentralgabe
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request leverages w3c/vc-data-model#1000
It defines the "instead of" production rules in terms of the
application/credential+ld+jsonmedia type.💥 Error: 522 💥
PR Preview failed to build. (Last tried on Jan 20, 2023, 11:35 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.