Add informative note about code reuse #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wind4Greg
requested review from
shigeya,
msporny,
davidlehn,
dlongley,
iherman,
dmitrizagidulin,
brianorwhatever and
brentzundel
and removed request for
tplooker
dlongley
approved these changes
Jan 15, 2024
TallTed
reviewed
Jan 18, 2024
…age. Co-authored-by: Dave Longley <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
TallTed
reviewed
Jan 19, 2024
Co-authored-by: Ted Thibodeau Jr <[email protected]>
TallTed
approved these changes
Jan 25, 2024
msporny
approved these changes
Feb 2, 2024
|
Informative, multiple reviews, changes requested and made, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #119 "Add note that implementers can reuse createHmacIdLabelMapFunction in createShuffledIdLabelMapFunction".
It does this by adding and informative note ;-)
Preview | Diff