-
Notifications
You must be signed in to change notification settings - Fork 112
Add guidance for credential+ld+json
for external
proof
#1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
added some suggestions to make it very clear what can and can't be done to make things very simple and hopefully avoid 1) confusion, 2) resulting type confusion issues (i.e. like what we keep seeing in x509 and related openssl CVEs) |
Co-authored-by: Dave Longley <[email protected]>
Of course, adding restrictions do define what can and can't be done. However, the specific restrictions added should have a clear rationale and be technologically defensible. So, the specific suggestion that you cannot use this media type with a verifiable credential that has an embedded proof ... serves what purpose? Where is that useful and what are the pros / cons? EDIT: Perhaps it's best to keep this thread of the conversation in #1014. |
converting to approve - did not mean to take discussion out of #1014 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Don't know about @mprorock's addition... on the fence about that one (but wouldn't object if it was merged w/ the corrections).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems to be unfinished. It refers to the term of "external proof", but it does not define what this means. Until that is properly defined, this is incomplete and should not be merged imho.
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@iherman external proof is defined here: https://w3c.github.io/vc-data-model/#proofs-signatures However I agree that Which is why people can't understand its relationship to |
I stand corrected. But #1033 (comment) explains why I went wrong: in the new section the term "external proof" appeared as a definition and not as a reference. |
Co-authored-by: Ivan Herman <[email protected]>
@iherman accepted your change suggestion, can you please re-review |
Co-authored-by: Dave Longley <[email protected]>
Editorial, multiple reviews, changes requested and made, no objections, merging. |
Remove proposed guidance that lacked consensus per @dlongley on: #1014
Preview | Diff