Run IDL analyses on curated branch, enable noEvent #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This duplicates the calls to Strudy in the analysis job: first pass analyzes the raw crawl results, second pass runs further analyses (not the same ones!) on the curated crawl results. IDL analyses are now done as part of the second pass. The rationale is that some IDL anomalies may be indirectly triggered by another IDL hiccup that we already identified and reported while doing data curation in Webref. This makes it at least theoretically possible to end up in a situation where we detect an anomaly twice (from two different angles). It seems better to run further IDL analyses on the curated branch instead. This is particularly needed for the new `noEvent` anomaly, which would otherwise report problems that our events patching already takes care of. The `noEvent` anomaly will create two issues next time the job runs: - one for `HTMLBodyElement.onorientationchange`, already covered in the spec: https://compat.spec.whatwg.org/#windoworientation-interface - one for `RTCIceTransport.onerror`, already tracked in: w3c/webrtc-ice#47
dontcallmedom
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This duplicates the calls to Strudy in the analysis job: first pass analyzes the raw crawl results, second pass runs further analyses (not the same ones!) on the curated crawl results. IDL analyses are now done as part of the second pass.
The rationale is that some IDL anomalies may be indirectly triggered by another IDL hiccup that we already identified and reported while doing data curation in Webref. This makes it at least theoretically possible to end up in a situation where we detect an anomaly twice (from two different angles). It seems better to run further IDL analyses on the curated branch instead.
This is particularly needed for the new
noEventanomaly, which would otherwise report problems that our events patching already takes care of.The
noEventanomaly will create two issues next time the job runs:HTMLBodyElement.onorientationchange, already covered in the spec: https://compat.spec.whatwg.org/#windoworientation-interfaceRTCIceTransport.onerror, already tracked in: Renameonerrortoonicecandidateerror? webrtc-ice#47