Repository navigation
Add Node v26 to tests workflow and engines; drop v22; use default version for lint - #812
Open
kfranqueiro wants to merge 3 commits into
Open
kfranqueiro wants to merge 3 commits into
kfranqueiro wants to merge 3 commits into
Conversation
deniak
reviewed
Sep 19, 2026
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| node-version: [22.x, 24.x] |
Member
There was a problem hiding this comment.
Same comment as for specberus. No need to keep node 22.
deniak
approved these changes
Sep 21, 2026
kfranqueiro
changed the title
deniak
approved these changes
Sep 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
26to the spec-generator tests workflow and toenginesinpackage.json, and removes22.I've also updated the lint workflow (which was running on two very old node versions) to use the default version and cache its dependencies, more in line with what specberus' lint workflow does.
All tests pass, and I did some manual testing locally with Node v26.8.2.
Note that this should probably warrant a major version bump due to dropping a version, especially since 22 is technically not EOL until next year.