Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new RNC, RNG, XSD #7

Merged
merged 5 commits into from
Mar 3, 2023
Merged

new RNC, RNG, XSD #7

merged 5 commits into from
Mar 3, 2023

Conversation

2007 -> 2005
@domel domel requested review from afs and rubensworks February 16, 2023 10:34
spec/result.rnc Outdated
#

namespace local = ""
namespace res = "http://www.w3.org/2005/SPARQL/results#"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the right fix to change 2007 to 2005 or vice versa - I'm quite unclear what is the best way to address the errata.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was 2007. I have changed to 2005

@afs
Copy link
Contributor

afs commented Feb 16, 2023

#9 created for changing the deployed schema. This needs to be done (by W3C team).

Copy link
Contributor

@afs afs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note an extra step is needed - recorded in #9.

@ericprud
Copy link
Member

Hi @domel , fabulous contribution but I'm not smart enough to use it.

I validated the 3rd example from SPARQL Query Results XML Format§2.3.1 (eliding the '...'s) and ran into namespace probs:

jing ./sparql-results-xml/spec/result.rng ./sparql-results-xml/2.3.1ex3.xml 
/home/eric/checkouts/w3c/./sparql-results-xml/2.3.1ex3.xml:2:56: error: element "sparql" not allowed anywhere; expected element "ns:sparql" (with xmlns:ns="http://www.w3.org/2005/SPARQL/results#")

Advice?

Copy link
Contributor

@afs afs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@domel
Copy link
Contributor Author

domel commented Feb 16, 2023

Now should be OK. I was check it by xmllint

@domel domel requested a review from afs February 16, 2023 15:54
@rubensworks
Copy link
Member

@domel Do you agree with the suggested changes from @TallTed?

domel and others added 3 commits March 3, 2023 08:44
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Typos

Co-authored-by: Ted Thibodeau Jr <[email protected]>
@domel
Copy link
Contributor Author

domel commented Mar 3, 2023

Done

@rubensworks rubensworks merged commit 33bd77a into main Mar 3, 2023
@rubensworks rubensworks deleted the XML-schemas branch March 3, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants