Skip to content

Conversation

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Nov 27, 2024

See whatwg/html#9893.

Closes #???

Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:

  • chore: fixes unrelated to the spec itself (e.g., fix to Github action, html tidy, spec config, etc.).
  • editorial: a non-normative change to the spec (e.g., fixing an example or typo, adding a note).
  • change: a normative change to existing engine behavior.
  • And use none if it's a new normative requirement.

If this is a "change", please explain what's significantly changing.
In particular, if the change results in potential backwards compatibility issues and content breakage, it needs to be justified.

For normative spec changes, please get implementation commitments anf file issues on the various engines during the review process. All tasks should be complete before merging.

Implementation commitment - primarily for "change" and other normative changes:

Tasks:


Preview | Diff

@noamr
Copy link
Contributor

noamr commented Nov 27, 2024

The change LGTM, but I see that the "principal realm" definition is not found? Does it need to be exported from somewhere, or explicitly imported?

index.html Outdated
<ol>
<li>Let |settings:environment settings object| be the |global|'s
[=global object/realm=]'s [=realm/principal realm=]'s
[=relevant settings object=].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there no relevant principal settings object? Wouldn't this require a lot of indirection everywhere?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be even better

@annevk
Copy link
Member

annevk commented Nov 27, 2024

(You can't merge this until the HTML ShadowRealm PR is considered done.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants